-
Notifications
You must be signed in to change notification settings - Fork 68
feat: in scala/metals, isHttpEnabled should be true by default. Also fixed an inconsistency between template & installer #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in scala/metals, isHttpEnabled should be true by default. Also fixed an inconsistency between template & installer #1346
Conversation
|
regarding this part: should this part be double quoted, like the code before this PR? Why is it necessary? |
|
Double quoted support path which have spaces |
| "programArgs": { | ||
| "windows": "\"${BASE_DIR}/metals.bat\"", | ||
| "default": "\"${BASE_DIR}/metals\"" | ||
| "windows": "${workingDir}/metals.bat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you did this change in this PR? What it is workingDir?
I suppose you want to reference metals file from the project dir, right?
If it that it should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I was copying from installer.json nearby, turns out I forgot the most important part:
"properties": {
"workingDir" : "$USER_HOME$/.lsp4ij/lsp/metals"
},
will add it back ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried it? I fear that it will not work, you need to diplicate this HOME dir in default and windows command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ff098cf to
dce33d0
Compare
in scala/metals, isHttpEnabled is true by default
dce33d0 to
60eeb5e
Compare
|
Please add feat: before your commit in order to it follows conventional commit. After that I think we can merge it |
|
Thanks @tribbloid ! |

No description provided.