Skip to content

Conversation

@tribbloid
Copy link
Contributor

No description provided.

@tribbloid tribbloid changed the title in scala/metals, isHttpEnabled is true by default in scala/metals, isHttpEnabled should be true by default. Also fixed an inconsistency between template & installer Oct 24, 2025
@tribbloid
Copy link
Contributor Author

regarding this part:

  "programArgs": {
    "windows": "${workingDir}/metals.bat",
    "default": "${workingDir}/metals"
  },

should this part be double quoted, like the code before this PR? Why is it necessary?

@angelozerr
Copy link
Contributor

Double quoted support path which have spaces

"programArgs": {
"windows": "\"${BASE_DIR}/metals.bat\"",
"default": "\"${BASE_DIR}/metals\""
"windows": "${workingDir}/metals.bat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you did this change in this PR? What it is workingDir?

I suppose you want to reference metals file from the project dir, right?

If it that it should be $PROJECT_DIR$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I was copying from installer.json nearby, turns out I forgot the most important part:

"properties": {
"workingDir" : "$USER_HOME$/.lsp4ij/lsp/metals"
},

will add it back ASAP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried it? I fear that it will not work, you need to diplicate this HOME dir in default and windows command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh you are right, properties are not supported in template, will change to:

"$USER_HOME$/.lsp4ij/lsp/metals/metals"

which totally works on Linux:
image

for other OS, give me some time

in scala/metals, isHttpEnabled is true by default
@angelozerr
Copy link
Contributor

Please add feat: before your commit in order to it follows conventional commit. After that I think we can merge it

@angelozerr angelozerr added this to the 0.19.0 milestone Oct 29, 2025
@angelozerr angelozerr added enhancement New feature or request user-defined LS labels Oct 29, 2025
@angelozerr angelozerr changed the title in scala/metals, isHttpEnabled should be true by default. Also fixed an inconsistency between template & installer feat: in scala/metals, isHttpEnabled should be true by default. Also fixed an inconsistency between template & installer Oct 29, 2025
@angelozerr angelozerr merged commit ef8c766 into redhat-developer:main Oct 29, 2025
6 of 7 checks passed
@angelozerr
Copy link
Contributor

Thanks @tribbloid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request user-defined LS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants