Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add/remove/edit helm repo (#673, #803) #795

Merged
merged 1 commit into from
May 27, 2024
Merged

feat: add/remove/edit helm repo (#673, #803) #795

merged 1 commit into from
May 27, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Apr 18, 2024 •
edited
Loading

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish force-pushed the issue-673 branch 4 times, most recently from 7d570bf to 403decb Compare April 19, 2024 15:17
@adietish adietish changed the title implemented 'add helm repo' (#673) feat: implemented 'add helm repo' (#673) Apr 19, 2024
@adietish adietish force-pushed the issue-673 branch 3 times, most recently from 0448fff to 5c1b9ff Compare April 22, 2024 15:32
@adietish adietish self-assigned this Apr 22, 2024
@adietish adietish changed the title feat: implemented 'add helm repo' (#673) feat: add/remove/edit helm repo (#673) Apr 22, 2024
@adietish adietish force-pushed the issue-673 branch 3 times, most recently from 5aeeea9 to cf19f5f Compare April 22, 2024 21:04
@adietish adietish mentioned this pull request Apr 22, 2024
Merged
@adietish
Copy link
Contributor Author

#803 and #802 are both minor (but annoying) defects I want to tackle once this basic implementation is merged.

@adietish adietish force-pushed the issue-673 branch 4 times, most recently from d821d07 to 516c61b Compare April 24, 2024 15:27
@adietish
Copy link
Contributor Author

#803 is now included in this PR.

@adietish adietish changed the title feat: add/remove/edit helm repo (#673) feat: add/remove/edit helm repo (#673,#803) Apr 24, 2024
@adietish adietish changed the title feat: add/remove/edit helm repo (#673,#803) feat: add/remove/edit helm repo (#673, #803) Apr 24, 2024
@adietish adietish force-pushed the issue-673 branch 2 times, most recently from 2caf837 to 4adeee5 Compare April 25, 2024 13:37
@adietish adietish marked this pull request as ready for review April 25, 2024 16:16
@adietish adietish requested a review from sbouchet April 26, 2024 18:24
@adietish
Copy link
Contributor Author

@sbouchet: corrected your findings, please re-review

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish
Copy link
Contributor Author

adietish commented May 6, 2024

@sbouchet please review. thanks!

@adietish
Copy link
Contributor Author

@sbouchet: intellij-common 1.9.6-SNAPSHOT now includes the breaking change in redhat-developer/intellij-common#228. This PR will not unless #802 is merged

@sbouchet sbouchet self-requested a review May 15, 2024 14:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Coverage on New Code (required ≥ 80%)
9.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sbouchet sbouchet mentioned this pull request May 27, 2024
Open
sbouchet
sbouchet approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

/override "Aggregated Test Report"

@redhat-developer redhat-developer deleted a comment from openshift-ci bot May 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report

In response to this:

/override "Aggregated Test Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

/override kubernetes-integration-tests

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

@adietish: Overrode contexts on behalf of adietish: kubernetes-integration-tests

In response to this:

/override kubernetes-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit daa3512 into redhat-developer:main May 27, 2024
17 of 19 checks passed
@adietish adietish deleted the issue-673 branch May 28, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

@sbouchet sbouchet

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want to be able to add, remove, edit helm repositories
2 participants
@adietish @sbouchet