Skip to content

Conversation

sadlerap
Copy link
Contributor

Bump kyverno to v1.15.2 by updating the helm chart to v3.5.2

Copy link
Contributor

🤖 Gemini AI Assistant Available

Hi @sadlerap! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

Copy link
Contributor

🤖 Hi @sadlerap, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@sadlerap sadlerap force-pushed the kyverno-1.15-development branch from 281a573 to 18e036e Compare September 29, 2025 13:00
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sadlerap
Copy link
Contributor Author

/retest

@sadlerap sadlerap force-pushed the kyverno-1.15-development branch from 18e036e to 2e55372 Compare September 29, 2025 19:16
@openshift-ci openshift-ci bot removed the lgtm label Sep 29, 2025
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 29, 2025

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/konflux-e2e-v418-optional 2e55372 link false /test konflux-e2e-v418-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadlerap sadlerap force-pushed the kyverno-1.15-development branch from 2e55372 to 2ec91a1 Compare September 29, 2025 22:44
@openshift-ci openshift-ci bot removed the lgtm label Sep 29, 2025
@sadlerap sadlerap force-pushed the kyverno-1.15-development branch from 2ec91a1 to 1b31135 Compare September 29, 2025 22:52
Bump kyverno to v1.15.2 by updating the helm chart to v3.5.2

Part-of: KFLUXINFRA-1963
Signed-off-by: Andy Sadler <[email protected]>
The ClusterPolicy `init-ns-integration` uses celPreconditions, which in
kyverno v1.15 are only allowed alongside cel validation rules.  Adjust
the policy to use JMESPath preconditions instead.

Part-of: KFLUXINFRA-1963
Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the kyverno-1.15-development branch from 1b31135 to 5bd1e34 Compare September 29, 2025 23:22
@sadlerap
Copy link
Contributor Author

@filariow @hugares please reapprove, I needed to repush to add a fix.

The bump from v1.13 to v1.15 introduces a new validation change in kyverno's webhooks, resulting in the following warning in argo:

admission webhook "validate-policy.kyverno.svc" denied the request: path: spec.rules[0].generate..: celPrecondition can only be used with validate.cel

One of our namespace bootstrapping policies is in violation of this validation, resulting in the second commit in this PR.

Our current chainsaw testing setup on top of kind doesn't run validation webhooks correctly (AIUI it's not picking up certs correctly, because openshift certificate manager doesn't run on our kind clusters), which is why this change fell through our testing setup. We may want to look into running our tests on openshift via prow in the future.

In good news, this validation failure was getting picked up in e2e tests, which was failing on the policies component not coming alive when trying to set up the clusters. However, e2e tests didn't trigger on the staging (#8216) and production (#8343) PRs due to this check not kicking in, which is why only this PR failed.

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 29, 2025
Copy link

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 776af0f into redhat-appstudio:main Sep 30, 2025
27 of 28 checks passed
@sadlerap sadlerap deleted the kyverno-1.15-development branch September 30, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants