-
Notifications
You must be signed in to change notification settings - Fork 313
kyverno: bump to v1.15.2 in development overlay #8344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kyverno: bump to v1.15.2 in development overlay #8344
Conversation
🤖 Gemini AI Assistant AvailableHi @sadlerap! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
🤖 Hi @sadlerap, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
281a573
to
18e036e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
18e036e
to
2e55372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sadlerap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2e55372
to
2ec91a1
Compare
2ec91a1
to
1b31135
Compare
Bump kyverno to v1.15.2 by updating the helm chart to v3.5.2 Part-of: KFLUXINFRA-1963 Signed-off-by: Andy Sadler <[email protected]>
The ClusterPolicy `init-ns-integration` uses celPreconditions, which in kyverno v1.15 are only allowed alongside cel validation rules. Adjust the policy to use JMESPath preconditions instead. Part-of: KFLUXINFRA-1963 Signed-off-by: Andy Sadler <[email protected]>
1b31135
to
5bd1e34
Compare
@filariow @hugares please reapprove, I needed to repush to add a fix. The bump from v1.13 to v1.15 introduces a new validation change in kyverno's webhooks, resulting in the following warning in argo:
One of our namespace bootstrapping policies is in violation of this validation, resulting in the second commit in this PR. Our current chainsaw testing setup on top of kind doesn't run validation webhooks correctly (AIUI it's not picking up certs correctly, because openshift certificate manager doesn't run on our kind clusters), which is why this change fell through our testing setup. We may want to look into running our tests on openshift via prow in the future. In good news, this validation failure was getting picked up in e2e tests, which was failing on the policies component not coming alive when trying to set up the clusters. However, e2e tests didn't trigger on the staging (#8216) and production (#8343) PRs due to this check not kicking in, which is why only this PR failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, hugares, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
776af0f
into
redhat-appstudio:main
Bump kyverno to v1.15.2 by updating the helm chart to v3.5.2