Skip to content

staging: remove sprayproxy from host clusters #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

staging: remove sprayproxy from host clusters #8264

merged 1 commit into from
Sep 29, 2025

Conversation

@sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Sep 22, 2025 •
edited by openshift-ci bot
Loading

With the completion of KFLUXINFRA-17901, we no longer need sprayproxy on the host clusters.

Remove it from the staging overlay.

Part of KFLUXINFRA-2240.

Footnotes

  1. https://issues.redhat.com/browse/KFLUXINFRA-1790 ↩

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

🤖 Gemini AI Assistant Available

Hi @sadlerap! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance

  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.

This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@openshift-ci openshift-ci bot requested review from elsony and ralphbean September 22, 2025 19:35
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

🤖 Hi @sadlerap, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@sadlerap sadlerap force-pushed the remove-host-specific-components-staging branch from 72760ad to cf24897 Compare September 22, 2025 19:36
hugares
hugares approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sadlerap sadlerap force-pushed the remove-host-specific-components-staging branch from cf24897 to 94a4661 Compare September 22, 2025 19:45
@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2025
@sadlerap sadlerap requested a review from hugares September 22, 2025 19:45
@sadlerap sadlerap force-pushed the remove-host-specific-components-staging branch 3 times, most recently from 1270099 to 7dab06a Compare September 22, 2025 19:51
@sadlerap
staging: remove sprayproxy from host clusters
4033bc9 
With the completion of KFLUXINFRA-1790[^1], we no longer need sprayproxy
on the host clusters.

Remove it from the staging overlay.

[^1]: https://issues.redhat.com/browse/KFLUXINFRA-1790

Part-of: KFLUXINFRA-2240
Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the remove-host-specific-components-staging branch from 7dab06a to 4033bc9 Compare September 22, 2025 21:30
hugares
hugares approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2025
@sadlerap
Copy link
Contributor Author

sadlerap commented Sep 23, 2025

/retest

2 similar comments
@sadlerap
Copy link
Contributor Author

sadlerap commented Sep 23, 2025

/retest

@sadlerap
Copy link
Contributor Author

sadlerap commented Sep 24, 2025

/retest

@sadlerap
Copy link
Contributor Author

sadlerap commented Sep 29, 2025

/retest

filariow
filariow approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2025

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/konflux-e2e-v418-optional 4033bc9 link false /test konflux-e2e-v418-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 20da383 into redhat-appstudio:main Sep 29, 2025
23 of 24 checks passed
@sadlerap sadlerap deleted the remove-host-specific-components-staging branch October 6, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugares hugares hugares approved these changes

@filariow filariow filariow approved these changes

@manish-jangra manish-jangra Awaiting requested review from manish-jangra

@elsony elsony Awaiting requested review from elsony

@ralphbean ralphbean Awaiting requested review from ralphbean

Assignees

@hugares hugares

@filariow filariow

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sadlerap @hugares @filariow