Skip to content

Conversation

aThorp96
Copy link
Contributor

@aThorp96 aThorp96 commented Sep 12, 2025

Summary:

  • Move former Approvers to emeritus.
  • Reviewers who are no longer actively maintaining pipelines-service were left as reviewers, but I don't mind removing from reviewers if preferable (cc @xinredhat WDYT?).
  • Add pipelines IC team and SMEs to Reviwers and Approvers

Details:

  • @Roming22 moved to emeritus - no longer working on Pipelines service
  • @adambkaplan moved to emeritus - no longer maintaining tekton results
  • @enarha promoted to approver - actively maintaining tekton results
  • @aThorp96 promoted to approver - working on pipelines service, leading IC team
  • @infernus01 added to reviewers - working on pipelines service, IC
  • @ab-ghosh added to reviewers - working on pipelines service, IC

- Roming22 moved to emeritus - no longer working on Pipelines service
- adambkaplan moved to emeritus - no longer maintaining tekton results
- enarha promoted to approver - actively maintaining tekton results
- aThorp96 promoted to approver - working on pipelines service, IC
- infernus01 added to reviewers - working on pipelines service, IC
- ab-ghosh added to reviewers - working on pipelines service, IC
Copy link
Contributor

Code Review by Gemini

The changes in the OWNERS file align perfectly with the descriptions provided in the commit message. All promotions, additions, and moves to emeritus status are correctly reflected in the diff.

No bugs or issues were found in this change. The file structure and updates are consistent with the intended modifications.

Copy link
Contributor

Code Review by Gemini

--- a/components/pipeline-service/OWNERS
+++ b/components/pipeline-service/OWNERS
@@ -6,10 +6,8 @@
   - aThorp96
 
 reviewers:
-  - Roming22
-  - adambkaplan
   - ramessesii2
   - xinredhat
   - enarha
   - aThorp96
   - mathur07

@infernus01
Copy link
Member

LGTM 😁

@seanconroy2021
Copy link
Member

Hey guys, any update on getting this merged :)

@scoheb scoheb self-requested a review September 18, 2025 14:37
Copy link
Member

@scoheb scoheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, scoheb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
Copy link
Member

/verify-owners

@openshift-merge-bot openshift-merge-bot bot merged commit 51eb875 into redhat-appstudio:main Sep 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants