Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konfluxui: clean proxy's configuration #5891

Merged

Conversation

filariow
Copy link
Member

@filariow filariow commented Mar 20, 2025

remove deprecated endpoints and unused headers

requires

Signed-off-by: Francesco Ilario [email protected]

@filariow filariow requested review from gbenhaim and removed request for sadlerap and abhinandan13jan March 20, 2025 09:11
@filariow filariow requested a review from sahil143 March 20, 2025 09:11
remove deprecated endpoints and unused headers

Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow force-pushed the kui-stg-clean-nginx branch from e48b682 to 36ff780 Compare March 20, 2025 09:13
@filariow filariow requested a review from sadlerap March 20, 2025 09:34
@filariow
Copy link
Member Author

/hold

@sahil143 unhold it when you think it can be merged

@gbenhaim
Copy link
Member

/approve

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

UI PR konflux-ci/konflux-ui#165 got merged
staging PR #5963

Copy link

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, gbenhaim, sadlerap, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 550c4e8 into redhat-appstudio:main Mar 28, 2025
6 checks passed
@filariow filariow deleted the kui-stg-clean-nginx branch March 28, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants