-
Notifications
You must be signed in to change notification settings - Fork 267
Add Role For Monitoring Release Pipelines #5818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Role For Monitoring Release Pipelines #5818
Conversation
Hi @rhartman93. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: monitor-release-pipeline-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be used for any type of pipeline though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying I should rename it to be more generic? or suggesting that there's a way I could make the role more tailored to release pipelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Deepak Chourasia <[email protected]>
Co-authored-by: Deepak Chourasia <[email protected]>
| We want to create a service account that can be used by users to automate monitoring the status of their managed |
hey folks, after my updates can someone re-check to see if this is ok? |
It could be, for now there is just one team requesting this, so i was going to make a dedicated account for their purposes, but we could create a "watcher" account to be used by multiple people? I'm not sure which is preferrable |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhartman93, scoheb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
f919503
into
redhat-appstudio:main
* First attempt at adding role to simply monitor release pipelines * Update components/release/base/release-pipeline-monitor-role.yaml Co-authored-by: Deepak Chourasia <[email protected]> * Update components/release/base/release-pipeline-monitor-role.yaml Co-authored-by: Deepak Chourasia <[email protected]> * Made name more generic --------- Co-authored-by: Deepak Chourasia <[email protected]> Signed-off-by: Hector Martinez <[email protected]>
We want to create a service account that can be used by users to automate monitoring the status of their managed release pipelines. The thought for now is it will only require:
permissions for: