Skip to content

Add Role For Monitoring Release Pipelines #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rhartman93
Copy link
Contributor

We want to create a service account that can be used by users to automate monitoring the status of their managed release pipelines. The thought for now is it will only require:

  • get
  • list
  • watch

permissions for:

  • pipelineruns
  • pipelines
  • pods
  • pods/logs

@openshift-ci openshift-ci bot requested review from davidmogar and johnbieren March 14, 2025 16:42
Copy link

openshift-ci bot commented Mar 14, 2025

Hi @rhartman93. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: monitor-release-pipeline-role
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be used for any type of pipeline though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying I should rename it to be more generic? or suggesting that there's a way I could make the role more tailored to release pipelines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more generic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gbenhaim
Copy link
Member

| We want to create a service account that can be used by users to automate monitoring the status of their managed
is it going to be a single service account that will be used by multiple users?

@rhartman93 rhartman93 requested a review from scoheb April 1, 2025 14:34
@rhartman93
Copy link
Contributor Author

hey folks, after my updates can someone re-check to see if this is ok?

@rhartman93
Copy link
Contributor Author

rhartman93 commented Apr 2, 2025

| We want to create a service account that can be used by users to automate monitoring the status of their managed is it going to be a single service account that will be used by multiple users?

It could be, for now there is just one team requesting this, so i was going to make a dedicated account for their purposes, but we could create a "watcher" account to be used by multiple people? I'm not sure which is preferrable

@scoheb
Copy link
Member

scoheb commented Apr 2, 2025

/approve
/lgtm

Copy link

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhartman93, scoheb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc
Copy link
Member

psturc commented Apr 3, 2025

/ok-to-test

@openshift-merge-bot openshift-merge-bot bot merged commit f919503 into redhat-appstudio:main Apr 3, 2025
5 checks passed
rh-hemartin pushed a commit to rh-hemartin/infra-deployments that referenced this pull request Apr 8, 2025
* First attempt at adding role to simply monitor release pipelines

* Update components/release/base/release-pipeline-monitor-role.yaml

Co-authored-by: Deepak Chourasia <[email protected]>

* Update components/release/base/release-pipeline-monitor-role.yaml

Co-authored-by: Deepak Chourasia <[email protected]>

* Made name more generic

---------

Co-authored-by: Deepak Chourasia <[email protected]>
Signed-off-by: Hector Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants