Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyverno's development overlay #5527

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

filariow
Copy link
Member

Signed-off-by: Francesco Ilario [email protected]

@filariow
Copy link
Member Author

/hold

@filariow filariow force-pushed the kyverno-development-values branch from 767888f to 2d6172f Compare February 11, 2025 22:51
@openshift-ci openshift-ci bot removed the approved label Feb 11, 2025
@filariow filariow force-pushed the kyverno-development-values branch from 2d6172f to 45bf9c9 Compare February 11, 2025 22:52
@filariow
Copy link
Member Author

/unhold

@filariow filariow force-pushed the kyverno-development-values branch 2 times, most recently from 5842504 to 662a809 Compare February 11, 2025 23:00
@filariow filariow requested a review from hugares February 11, 2025 23:00
@filariow filariow force-pushed the kyverno-development-values branch from 662a809 to 96817e5 Compare February 11, 2025 23:01
@sadlerap
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@filariow filariow requested a review from gbenhaim February 12, 2025 08:27
@filariow filariow changed the title kyverno values for development overlay kyverno's development overlay Feb 12, 2025
@filariow filariow marked this pull request as draft February 12, 2025 10:37
@filariow filariow marked this pull request as ready for review February 12, 2025 12:44
@openshift-ci openshift-ci bot requested a review from sadlerap February 12, 2025 12:44
@filariow filariow force-pushed the kyverno-development-values branch 3 times, most recently from a0a33f8 to 0d42f14 Compare February 12, 2025 19:10
@filariow filariow force-pushed the kyverno-development-values branch from 0d42f14 to 8feaf0e Compare February 13, 2025 11:12
components/kyverno/development/kustomization.yaml Outdated Show resolved Hide resolved
components/kyverno/staging/kustomization.yaml Outdated Show resolved Hide resolved
components/kyverno/staging/kyverno-pre.yaml Outdated Show resolved Hide resolved
components/kyverno/development/kyverno-pre.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 14, 2025
@sadlerap
Copy link
Contributor

Linter warnings:

warning: container "kyverno" does not have a read-only root file system
object: konflux-kyverno/kyverno-admission-controller apps/v1, Kind=Deployment
 = Indicates when containers are running without a read-only root filesystem.
 = Set readOnlyRootFilesystem to true in the container securityContext.

warning: container "kyverno" is not set to runAsNonRoot
object: konflux-kyverno/kyverno-admission-controller apps/v1, Kind=Deployment
 = Indicates when containers are not set to runAsNonRoot.
 = Set runAsUser to a non-zero number and runAsNonRoot to true in your pod or container securityContext. Refer to https://kubernetes.io/docs/tasks/configure-pod-container/security-context/ for details.

warning: 2 warnings emitted

@filariow filariow force-pushed the kyverno-development-values branch from 5e02482 to f2fbb3b Compare February 14, 2025 21:33
@openshift-ci openshift-ci bot removed the lgtm label Feb 14, 2025
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 14, 2025
Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: filariow, sadlerap
Once this PR has been reviewed and has the lgtm label, please assign gbenhaim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants