Add per-platform instance tags #5486
Conversation
|
In general, this approach is OK for me. I have the following tag format proposal though: i..e The reason for that is that some IBM accounts hosts both staging and prod VMs, and it has to have different tags for the:
And I would like ask to add more explicit examples into the documentation, so that fuctionality become more trasparent. |
enkeefe00
force-pushed
the
add-instance-tags-to-VM-flavors
branch
from
f3229dd to
c977bec
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enkeefe00, mshaposhnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When determining if a particular VM instance can be created, the VM flavor's maximum number of instances is compared to the current number of instances with the same instance-tag to ensure no more than the maximum number of VMs are created. Since the current configurations have all flavors using the same instance tag, the count of unique instances (flavors, in this case) is wrong. Adding per-platform/flavor instance tags should fix this.
enkeefe00
force-pushed
the
add-instance-tags-to-VM-flavors
branch
from
c977bec to
bca2617
Compare
|
@hugares or @mshaposhnik can you guys give this an LGTM so I can try to test it in the staging clusters? |
openshift-merge-bot
bot
merged commit c57030c
into
redhat-appstudio:main
When determining if a particular VM instance can be created, the VM flavor's maximum number of instances is compared to the current number of instances with the same
instance-tagto ensure no more than the maximum number of VMs are created. Since the current configurations have all flavors using the same instance tag, the count of unique instances (flavors, in this case) is wrong. Adding per-platform/flavor instance tags should fix this.