Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1 - Fixed operator logic to perform "contains" searches #182

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

xC0uNt3r7hr34t
Copy link
Contributor

This is limited to SentinelOne Product. The logic for S1 powerquery queries being built was using the "in" operator which would not perform a full contains match on fields. The code was updated to use the "contains" operator instead which works with the rest of the logic and can still support searching multiple values. After testing all queries work as expected and expected results are now properly returned.

Example:

src.process.name contains ('megasync', 'rclone')
src.process.name in ('megasync', 'rclone')

"in" logic does not match a src.process.name of "rclone.exe", but using contains it now will match this event.

@TreWilkinsRC
Copy link
Contributor

Hey @xC0uNt3r7hr34t ,

Would you be able to update the test_nested_process_search_pq_over_max_char_limit and test_nested_process_search_pq pytests to match the changes made?

'in' -> 'contains'

@xC0uNt3r7hr34t
Copy link
Contributor Author

@TreWilkinsRC changes applied, should be good to merge.

@rc-csmith rc-csmith merged commit da549f0 into redcanaryco:master Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants