Add tests for python code #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberbuff
commented
Apr 27, 2024
Comment on lines
+7
to
+8
| paths: | ||
| - "atomic_red_team/**/*.py" |
There was a problem hiding this comment.
Run python tests only on python file changes in atomic_red_team
cyberbuff
commented
Apr 27, 2024
Comment on lines
+13
to
+14
| from atomic_red_team.common import used_guids_file, atomics_path | ||
| from atomic_red_team.guid import ( |
There was a problem hiding this comment.
Absolute paths are required for running python tests
cyberbuff
commented
Apr 27, 2024
| @@ -0,0 +1,18 @@ | |||
| attack_technique: T1003 | |||
There was a problem hiding this comment.
atomic_red_team/tests would contain all the test cases for code within atomic_red_team/**/*.py
clr2of8
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Added tests for python code to find defects earlier
Testing:
Tested on PRs #16
Associated Issues:
generate-docsfor now. Github push protection doesn't have per file ignores. Its either all or none.