Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable windows users to build the android project #103

Merged
merged 2 commits into from
May 14, 2023

Conversation

DominicD
Copy link
Contributor

Hi I played around a bit with crux and I was able to build the android example with these changes.
Maybe related to #82 altough I am not even sure what effect the toolchain file actually has?

The cli example also works. The others I have not tried yet.
I thought I will provide this and maybe a nice discussion could emerge

@StuartHarris
Copy link
Member

Thanks @DominicD ! Much appreciated. Let us know how you get on with the other examples on Windows, and if there's any more to add to this PR. 👍

@DominicD
Copy link
Contributor Author

DominicD commented Apr 24, 2023

@StuartHarris For the android project it would maybe make sense to add a hint that the ndkVersion needs to match the one in shared/build.gradle this took me some time to figure out.

After installing wasm-pack manually (see modified Readme.md) web-nextjs worked.

I was also able to run web-yew after I found this: trunk-rs/trunk#534
I had to uninstall trunk and then install with cargo install --locked trunk
As this might be fixed I don't know if you want to do something at all about that?

Tauri works as well.

So except for iOS (which obviously won't work) everything in the counter example works fine.

@DominicD
Copy link
Contributor Author

@StuartHarris Hi Stuart I don't want to annoy you. I was just wondering if there is something else you want from me or is it fine to merge it?

Copy link
Member

@StuartHarris StuartHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominicD my sincere apologies, and thanks doing this. None of us use windows regularly, hence our inability to test and slow response! 😓 But happy to merge.

@StuartHarris StuartHarris merged commit 8990bea into redbadger:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants