Skip to content

Optionally emit an embeddable C-header for converted 4bpps#49

Open
lhearachel wants to merge 1 commit intored031000:masterfrom
lhearachel:embed-headers
Open

Optionally emit an embeddable C-header for converted 4bpps#49
lhearachel wants to merge 1 commit intored031000:masterfrom
lhearachel:embed-headers

Conversation

@lhearachel
Copy link
Contributor

No description provided.

@red031000
Copy link
Owner

what is this for? I don't really get it

@lhearachel
Copy link
Contributor Author

what is this for? I don't really get it

There are a few instances in the gen4 games where the raw tile-data of a 4bpp is embedded into the game code, e.g., the tiles used by the healthbar and status icons in battle. The idea here is to be able to store those as PNGs in the source trees, so they need to be converted into a table of bytes that can be #included into the code at build-time.

Emerald solved this with scaninc as a custom preprocessor; neither Platinum nor Heart Gold use scaninc, and asking either to take on that dependency instead of enabling this as a feature of nitrogfx seems less than ideal, IMO.

@red031000
Copy link
Owner

ok that sounds fine, will give it a proper review later, but for now changing the preprocessor constant would be a good start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants