Automatically resolve ceph daemon crash #11273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fbalak <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
fbalak
force-pushed
the
resolve_daemon_crash
branch
from
49c8d82 to
cc9c1ac
Compare
prsurve
reviewed
Jan 30, 2025
| @@ -2489,13 +2489,15 @@ def check_ceph_health_not_ok(): | |||
| sampler.wait_for_func_status(True) | |||
|
|
|||
|
|
|||
| def ceph_health_check(namespace=None, tries=20, delay=30): | |||
| def ceph_health_check(namespace=None, tries=20, delay=30, resolve_daemon_crash=True): | |||
There was a problem hiding this comment.
I feel that the value resolve_daemon_crash should not be set as TRUE by default in some cases, we can actually miss a bug just by archiving it. Value should be set true for specific tests only and not default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.