Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setter function for vault_path_token #11181

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

shivamdurgbuns
Copy link
Member

@shivamdurgbuns shivamdurgbuns commented Jan 21, 2025

Adding setter function for vault_path_token to work in tests.
addresses issue: #11180

@shivamdurgbuns shivamdurgbuns requested a review from a team as a code owner January 21, 2025 10:34
ocs_ci/utility/kms.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@avd-sagare
Copy link
Contributor

Checked above fix with below job and it moved from that point successfully.
https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-deploy-ocs-cluster/45862/consoleFull

Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avd-sagare, dahorak, petr-balogh, shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shivamdurgbuns shivamdurgbuns added the Verified Mark when PR was verified and log provided label Jan 21, 2025
@petr-balogh petr-balogh merged commit 1f886a1 into red-hat-storage:master Jan 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants