Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_bucket_logs.py - Adding skip on external deployments following issue 10983 #11173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test_bucket_logs.py - Adding skip on external deployments following issue 10983 #11173

wants to merge 1 commit into from

Conversation

ypersky1980
Copy link
Contributor

This PR contains only adding a skip following #10983 ( the test was failing on external deployments).

@ypersky1980 ypersky1980 requested a review from a team as a code owner January 20, 2025 22:14
@ypersky1980 ypersky1980 mentioned this pull request Jan 20, 2025
Open
@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Jan 21, 2025
@ypersky1980
Copy link
Contributor Author

I've put a "Verified" label since the change is only adding a skip marker.

ocs-ci
ocs-ci reviewed Jan 21, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job state: ABORTED.

@ypersky1980
Copy link
Contributor Author

The validation was stopped on purpose , the job did not start and was in a queue.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@udaysk23 udaysk23 udaysk23 approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

Assignees

@sagihirshfeld sagihirshfeld

@udaysk23 udaysk23

Labels
lgtm size/XS Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ypersky1980 @sagihirshfeld @ocs-ci @udaysk23