Improvements for MG collections #11161
Conversation
petr-balogh
force-pushed
the
improvmentes_for_mg_collections
branch
3 times, most recently
from
c368dd8 to
eabf343
Compare
|
Trying to verify here: |
petr-balogh
force-pushed
the
improvmentes_for_mg_collections
branch
from
eabf343 to
752cfd4
Compare
|
New verification triggered here: |
petr-balogh
force-pushed
the
improvmentes_for_mg_collections
branch
2 times, most recently
from
0befd70 to
bfe7cf7
Compare
|
Verification job: |
petr-balogh
force-pushed
the
improvmentes_for_mg_collections
branch
2 times, most recently
from
2b07848 to
a272f62
Compare
|
Verification job: |
Fixes: red-hat-storage#10526 Fixes: red-hat-storage#11159 Several improvements in MG logs like preventing running MG over and over when it's still failing or getting timeouted. Collecting OCP logs for Ecosystem tests like upgrade decorated with purple squad. Not collect logs again at the end of execution on success when it was collected at least once during execution by some failed test. Signed-off-by: Petr Balogh <[email protected]>
petr-balogh
force-pushed
the
improvmentes_for_mg_collections
branch
from
a272f62 to
8d56cdd
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "mcg", | ||
| "purple_squad", | ||
| } | ||
| # For every failure in MG we are trying to extend next attempt by 20 minutes |
There was a problem hiding this comment.
this would be up to 2 hours wait (20 min + 40 min + 60 min), in case the default max_mg_fail_attempts is being used.
Isn't it too much time?
| max_mg_fail_attempts = config.REPORTING.get("max_mg_fail_attempts") | ||
| if skip_after_max_fail: | ||
| with mg_lock: | ||
| if mg_fail_count > max_mg_fail_attempts: |
There was a problem hiding this comment.
are we deleting the MG dir structure in case of timeout failure?
Fixes: #10526
Fixes: #11159
Several improvements in MG logs like preventing running MG over and over
when it's still failing or getting timeouted.
Collecting OCP logs for Ecosystem tests like upgrade decorated with purple
squad.
Not collect logs again at the end of execution on success when it was
collected at least once during execution by some failed test.