VM hot plugging and unplugging #11149

ayush-patni · 2025-01-15T06:54:07Z

This PR consists of test cases resp for CNV: Verify that hotplugging and hot unplugging of a PVC to/from a VM works

Signed-off-by: AYUSH-D-PATNI <[email protected]>

…e_disk_hot_plugging_unplugging.py Signed-off-by: AYUSH-D-PATNI <[email protected]>

Signed-off-by: AYUSH-D-PATNI <[email protected]>

openshift-ci · 2025-01-15T06:54:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayush-patni

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_hotplug_unplug.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_hotplug_unplug.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_hotplug_unplug.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_hotplug_unplug.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

parikshithb · 2025-01-17T09:36:26Z

ocs_ci/helpers/cnv_helpers.py

+        volume_name (str): Name of the volume to verify
+
+    Returns:
+         str: stdout of command


return is bool

parikshithb · 2025-01-17T09:37:00Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            vm_obj.restart(wait=True, verify=True)
+
+            # Verify that the disk is still attached
+            verifyvolume(vm_obj, volume_name=pvc_obj.name)


assert here if verification is not successfull

parikshithb · 2025-01-17T09:37:50Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            ), f"Failed to unplug disk from VM {vm_obj.name}"
+
+            # Confirm disk removal
+            if not verifyvolume(vm_obj, volume_name=pvc_obj.name):


assert here as well

parikshithb · 2025-01-17T09:38:05Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+                )
+                run_dd_io(vm_obj=vm_obj, file_path=file_paths[1])
+            else:
+                pytest.fail(


can be part of assert message

parikshithb · 2025-01-17T09:43:11Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+
+            # Hotplug the PVC to the VM
+            vm_obj.addvolume(volume_name=pvc_obj.name)
+            verifyvolume(vm_obj, volume_name=pvc_obj.name)


assert here as well

parikshithb · 2025-01-17T09:47:41Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+
+@magenta_squad
+@workloads
+@pytest.mark.polarion_id("OCS-")


polarion id

hnallurv · 2025-01-17T09:53:57Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            9. login into VM and confirm disk is no longer listed.
+            10 Repeat the above tests for DVT based VM
+        """
+


Please consider making this as common function(s) so it can be used by other tests

As per today's discussion, we'll be updating addvolume as enhancement
https://github.com/red-hat-storage/ocs-ci/pull/11149/files#r1923196525

Signed-off-by: AYUSH-D-PATNI <[email protected]>

avd-sagare · 2025-01-21T07:21:17Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            log.info(f"Disks before hotplug:\n{before_disks}")
+
+            # Hotplug the PVC to the VM
+            vm_obj.addvolume(volume_name=pvc_obj.name)


can we add multiple hot disks?

PrasadDesala · 2025-01-21T07:23:07Z

ocs_ci/helpers/cnv_helpers.py

+    cmd = f"oc get vm {vm_obj.name} -o=jsonpath='{{.spec.volumes}}'"
+    output = run_cmd(cmd=cmd)


you can replace it with vm_obj.get()

PrasadDesala · 2025-01-21T07:24:37Z

ocs_ci/helpers/cnv_helpers.py

+
+    Args:
+        vm_obj (str): vm obj
+        volume_name (str): Name of the volume to verify


Suggested change

volume_name (str): Name of the volume to verify

volume_name (str): Name of the volume (PVC) to verify

PrasadDesala · 2025-01-21T07:29:41Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            # Perform I/O operation on the new disk
+            log.info(
+                f"Running I/O operation on the newly attached disk in VM {vm_obj.name}"
+            )


from the log message, it looks like you are running IO to the newly attached disk. How are you making sure that the created file indeed goes to the new disk?

PrasadDesala · 2025-01-21T07:30:39Z

tests/functional/workloads/cnv/test_vm_single_disk_hot_plugging_unplugging.py

@@ -33,5 +33,5 @@ def test_vm_single_disk_hot_plugging_unplugging(self, cnv_workload, setup_cnv):
            access_mode=constants.ACCESS_MODE_RWX,
            volume_mode=constants.VOLUME_MODE_BLOCK,
        )
-        vm_obj.addvolme(volume_name=pvc_obj.name)
+        vm_obj.addvolume(volume_name=pvc_obj.name)


since this test is covered with the new test in this PR, the old test can be depreciated

PrasadDesala · 2025-01-21T07:32:28Z

tests/functional/workloads/cnv/test_vm_hotplug_unplug.py

+            assert verifyvolume(
+                vm_obj, volume_name=pvc_obj.name
+            ), f"Unable to found volume {pvc_obj.name} mounted on VM: {vm_obj.name}"


you can add an additional arg like verify the addvolume function and move the verification code under it in the function. that way you can remove the repeated verification code in the test calling that function

AYUSH-D-PATNI and others added 12 commits December 20, 2024 14:08

added two tests

fe7879c

Signed-off-by: AYUSH-D-PATNI <[email protected]>

improvised test case as per cmts

5411c6d

Signed-off-by: AYUSH-D-PATNI <[email protected]>

logg

0d645b1

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added pvc_clone_factory fixture and better logs

beb069f

Signed-off-by: AYUSH-D-PATNI <[email protected]>

Merge branch 'red-hat-storage:master' into master

13f75e2

Merge branch 'red-hat-storage:master' into hot-plug-unplug

10434e0

removed two tcs

5e0d6cd

Signed-off-by: AYUSH-D-PATNI <[email protected]>

Merge branch 'red-hat-storage:master' into hot-plug-unplug

8f820bd

adding test case test_vm_hotplug_unplug.py with updated test_vm_singl…

909ad50

…e_disk_hot_plugging_unplugging.py Signed-off-by: AYUSH-D-PATNI <[email protected]>

update in hotplug tc cmt

b50294d

Signed-off-by: AYUSH-D-PATNI <[email protected]>

updated hotplug-unplug tc n verify in vm

80337ef

Signed-off-by: AYUSH-D-PATNI <[email protected]>

Merge branch 'red-hat-storage:master' into hot-plug-unplug

69959a4

ayush-patni requested review from a team as code owners January 15, 2025 06:54

pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 15, 2025

ayush-patni requested review from parikshithb, hnallurv, avd-sagare and PrasadDesala January 15, 2025 06:58

ocs-ci reviewed Jan 15, 2025

View reviewed changes

ayush-patni added 2 commits January 16, 2025 14:27

Update cmt in verify_volume

288ac69

Update cnv_helpers.py

1772620

parikshithb reviewed Jan 17, 2025

View reviewed changes

hnallurv reviewed Jan 17, 2025

View reviewed changes

ayush-patni added the team/e2e E2E team related issues/PRs label Jan 17, 2025

update as per review cmt

797bf72

Signed-off-by: AYUSH-D-PATNI <[email protected]>

avd-sagare reviewed Jan 21, 2025

View reviewed changes

PrasadDesala reviewed Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VM hot plugging and unplugging #11149

VM hot plugging and unplugging #11149

ayush-patni commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

parikshithb Jan 17, 2025

ayush-patni Jan 20, 2025

parikshithb Jan 17, 2025

ayush-patni Jan 20, 2025

parikshithb Jan 17, 2025

ayush-patni Jan 20, 2025

parikshithb Jan 17, 2025

parikshithb Jan 17, 2025

ayush-patni Jan 20, 2025

parikshithb Jan 17, 2025

hnallurv Jan 17, 2025

ayush-patni Jan 21, 2025

avd-sagare Jan 21, 2025

PrasadDesala Jan 21, 2025

PrasadDesala Jan 21, 2025

PrasadDesala Jan 21, 2025

PrasadDesala Jan 21, 2025

PrasadDesala Jan 21, 2025

		cmd = f"oc get vm {vm_obj.name} -o=jsonpath='{{.spec.volumes}}'"
		output = run_cmd(cmd=cmd)

	volume_name (str): Name of the volume to verify
	volume_name (str): Name of the volume (PVC) to verify

VM hot plugging and unplugging #11149

Are you sure you want to change the base?

VM hot plugging and unplugging #11149

Conversation

ayush-patni commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment