Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label the s3cli pod's Namespace with S3CLI_APP_LABEL to ignore potential false leftover error #11147

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Label the s3cli pod's Namespace with S3CLI_APP_LABEL to ignore potential false leftover error #11147

merged 1 commit into from
Jan 21, 2025

Conversation

sagihirshfeld
Copy link
Contributor

Fixes #11142

@sagihirshfeld sagihirshfeld added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Jan 14, 2025
@sagihirshfeld sagihirshfeld self-assigned this Jan 14, 2025
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner January 14, 2025 11:59
ocs-ci
ocs-ci reviewed Jan 14, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_namespace_crd.py::TestNamespace::test_namespace_bucket_creation_crd[AWS-OC-Single] tests/functional/object/mcg/test_namespace_crd.py::TestNamespace::test_write_to_aws_read_from_nsb_crd
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added the Verified Mark when PR was verified and log provided label Jan 14, 2025
ypersky1980
ypersky1980 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 73b2443 into red-hat-storage:master Jan 21, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@keesturam keesturam keesturam approved these changes

@udaysk23 udaysk23 Awaiting requested review from udaysk23

@mashetty330 mashetty330 Awaiting requested review from mashetty330

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@ypersky1980 ypersky1980

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
4 participants
@sagihirshfeld @keesturam @ocs-ci @ypersky1980