Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add screenshot to prove numbers in logs #11144

Merged
merged 1 commit into from
Jan 22, 2025
Merged

add screenshot to prove numbers in logs #11144

merged 1 commit into from
Jan 22, 2025

Conversation

DanielOsypenko
Copy link
Contributor

test fails but we don't have screenshot of actual storage capacity

fixes: 11143

@DanielOsypenko DanielOsypenko added the Squad/Black Covers UI specific test cases such as ODF Dashboard etc. label Jan 14, 2025
@DanielOsypenko DanielOsypenko self-assigned this Jan 14, 2025
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner January 14, 2025 10:12
@DanielOsypenko DanielOsypenko mentioned this pull request Jan 14, 2025
Open
@DanielOsypenko
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@DanielOsypenko: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, dahorak, DanielOsypenko, ebondare

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit 33827b7 into red-hat-storage:master Jan 22, 2025
6 of 7 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@DanielOsypenko: new pull request created: #11189

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am-agrawa am-agrawa am-agrawa approved these changes

@ebondare ebondare ebondare approved these changes

@dahorak dahorak dahorak approved these changes

@yitzhak12 yitzhak12 Awaiting requested review from yitzhak12

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@dahorak dahorak

@ebondare ebondare

@DanielOsypenko DanielOsypenko

@am-agrawa am-agrawa

Labels
lgtm size/XS Squad/Black Covers UI specific test cases such as ODF Dashboard etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielOsypenko @openshift-cherrypick-robot @dahorak @ebondare @am-agrawa