Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable overwrite for storing IBM cloud buckets #11109

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Jan 6, 2025

Signed-off-by: vavuthu [email protected]

@vavuthu vavuthu requested a review from a team as a code owner January 6, 2025 11:39
@vavuthu vavuthu changed the title fix variable override for storing IBM cloud buckets fix variable overwrite for storing IBM cloud buckets Jan 6, 2025
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Jan 6, 2025
petr-balogh
petr-balogh previously approved these changes Jan 6, 2025
@vavuthu vavuthu force-pushed the fix_buckets_variable branch from fef1ca2 to 89e52e7 Compare January 7, 2025 05:43
@openshift-ci openshift-ci bot removed the lgtm label Jan 7, 2025
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jan 7, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 7, 2025
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh, shylesh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit e32843f into red-hat-storage:master Jan 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S PR that changes 10-29 lines team/ecosystem Ecosystem team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants