-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV abrupt shutdown cluster while VMs in different state. #11088
base: master
Are you sure you want to change the base?
CNV abrupt shutdown cluster while VMs in different state. #11088
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avd-sagare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12f0c37
to
42ef244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: asagare-cnv30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: asagare-cnv30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
a76e416
to
5dda06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: asagare-cnv03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Signed-off-by: Avdhoot <[email protected]>
Signed-off-by: Avdhoot <[email protected]>
Signed-off-by: Avdhoot <[email protected]>
Signed-off-by: Avdhoot <[email protected]>
Signed-off-by: Avdhoot <[email protected]>
5dda06c
to
e9fbe85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: asagare-cnv-shut
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: asagare-cnv03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
# Stop all the VMs created. | ||
for vm_obj in all_vms: | ||
vm_obj.stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cnv_workload() fixture will take care of stopping the VM's. You can delete these lines
source_csums[vm_obj.name] = source_csum | ||
|
||
# Create VM using cloned pvc of source VM PVC | ||
all_vms[1].stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomly select a VM instead of hardcoding it. You are doing the same for many other places in the test below
except Exception as ex: | ||
logger.error("Failed at cluster health check!!") | ||
raise ex | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to also do cnv side health check
pytest.param("False", marks=pytest.mark.polarion_id("OCS-6316")), | ||
], | ||
) | ||
def test_vm_abrupt_shutdown_cluster( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, you are doing both garceful and abrupt with parametrize, please update the test func name accordingly
@@ -0,0 +1,185 @@ | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can rename the test file to test_cluster_shutdown_recovery.py
No description provided.