Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV abrupt shutdown cluster while VMs in different state. #11088

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

avd-sagare
Copy link
Contributor

No description provided.

@avd-sagare avd-sagare requested a review from a team as a code owner January 1, 2025 10:47
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 1, 2025
Copy link

openshift-ci bot commented Jan 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avd-sagare

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avd-sagare avd-sagare force-pushed the cnv_abrupt_shutdown_start branch 2 times, most recently from 12f0c37 to 42ef244 Compare January 1, 2025 11:11
@avd-sagare avd-sagare changed the title [WIP] CNV abrupt shutdown cluster while VMs in different state. CNV abrupt shutdown cluster while VMs in different state. Jan 2, 2025
ocs-ci

This comment was marked as outdated.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: asagare-cnv30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: asagare-cnv30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

@avd-sagare avd-sagare force-pushed the cnv_abrupt_shutdown_start branch from a76e416 to 5dda06c Compare January 3, 2025 13:28
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: asagare-cnv03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@avd-sagare avd-sagare added Verified Mark when PR was verified and log provided team/e2e E2E team related issues/PRs Squad/Magenta and removed Squad/Magenta labels Jan 4, 2025
@avd-sagare avd-sagare force-pushed the cnv_abrupt_shutdown_start branch from 5dda06c to e9fbe85 Compare January 7, 2025 10:05
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: asagare-cnv-shut
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: asagare-cnv03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_cnv_shutdown_start.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

Comment on lines +183 to +185
# Stop all the VMs created.
for vm_obj in all_vms:
vm_obj.stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cnv_workload() fixture will take care of stopping the VM's. You can delete these lines

source_csums[vm_obj.name] = source_csum

# Create VM using cloned pvc of source VM PVC
all_vms[1].stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomly select a VM instead of hardcoding it. You are doing the same for many other places in the test below

except Exception as ex:
logger.error("Failed at cluster health check!!")
raise ex

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to also do cnv side health check

pytest.param("False", marks=pytest.mark.polarion_id("OCS-6316")),
],
)
def test_vm_abrupt_shutdown_cluster(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, you are doing both garceful and abrupt with parametrize, please update the test func name accordingly

@@ -0,0 +1,185 @@
import logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rename the test file to test_cluster_shutdown_recovery.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants