Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AMQ setup by cloning the latest compatible branch of strimzi-kafka-operator #11082

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix AMQ setup by cloning the latest compatible branch of strimzi-kafka-operator #11082

merged 2 commits into from
Jan 6, 2025

Conversation

sagihirshfeld
Copy link
Contributor

Fixes #11081

@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link RGW Issues related to the Ceph Object Gateway Squad/Magenta Squad/Red labels Dec 25, 2024
@sagihirshfeld sagihirshfeld self-assigned this Dec 25, 2024
ocs-ci
ocs-ci reviewed Dec 25, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418vs03
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/workloads/app/amq/test_rgw_kafka_notifications.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Dec 25, 2024
@sagihirshfeld sagihirshfeld marked this pull request as ready for review December 25, 2024 14:10
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner December 25, 2024 14:10
udaysk23
udaysk23 previously approved these changes Dec 26, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Dec 26, 2024
@sagihirshfeld
Fix clarifying comment
4944419 
Signed-off-by: Sagi Hirshfeld <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 30, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 31, 2024
ypersky1980
ypersky1980 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, PrasadDesala, sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit efb5fff into red-hat-storage:master Jan 6, 2025
6 of 7 checks passed
paraggit added a commit to paraggit/ocs-ci that referenced this pull request Jan 7, 2025
@paraggit
Test Automation for encryption dashboard summary
89be3a8 
Signed-off-by: Parag Kamble <[email protected]>

Removed constructor from the class ObjectDetails.

Signed-off-by: Parag Kamble <[email protected]>

Fixed black Issue

Signed-off-by: Parag Kamble <[email protected]>

Created a encryption UI maping variables in the constnts.py file

Signed-off-by: Parag Kamble <[email protected]>

[4.18] Test bucket replication with versioning - utility functions and happy path validation (red-hat-storage#10957)

Signed-off-by: Sagi Hirshfeld <[email protected]>

Fix AMQ setup by cloning the latest compatible branch of strimzi-kafka-operator (red-hat-storage#11082)

Signed-off-by: Sagi Hirshfeld <[email protected]>

Created a EncryptionModule class and moved the encryption summary check functionality in same class

Signed-off-by: Parag Kamble <[email protected]>
@vkathole
Copy link
Contributor

/cherrypick release-4.17

@vkathole
Copy link
Contributor

/cherrypick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@vkathole: new pull request created: #11136

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2025
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@vkathole: new pull request created: #11137

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@PrasadDesala PrasadDesala PrasadDesala approved these changes

@keesturam keesturam keesturam approved these changes

@udaysk23 udaysk23 udaysk23 left review comments

@mashetty330 mashetty330 Awaiting requested review from mashetty330

@Akarsha-rai Akarsha-rai Awaiting requested review from Akarsha-rai

Assignees

@keesturam keesturam

@PrasadDesala PrasadDesala

@sagihirshfeld sagihirshfeld

@udaysk23 udaysk23

@ypersky1980 ypersky1980

Labels
lgtm RGW Issues related to the Ceph Object Gateway size/XS Squad/Magenta Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMQ setup fails at test_rgw_kafka_notifications due to recent strimzi-kafka-operator changes
8 participants
@sagihirshfeld @vkathole @openshift-cherrypick-robot @keesturam @PrasadDesala @ocs-ci @udaysk23 @ypersky1980