Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.18] Test MCG bucket notifications - utility functions and happy path validation #11041

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[4.18] Test MCG bucket notifications - utility functions and happy path validation #11041

merged 3 commits into from
Jan 28, 2025

Conversation

sagihirshfeld
Copy link
Contributor

@sagihirshfeld sagihirshfeld commented Dec 11, 2024 •
edited
Loading

Cover the happy path of MCG bucket notifications: https://url.corp.redhat.com/b0dfa7e

@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link DO NOT MERGE Do not merge this change!! MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Dec 11, 2024
@sagihirshfeld sagihirshfeld self-assigned this Dec 11, 2024
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Dec 11, 2024
@sagihirshfeld sagihirshfeld mentioned this pull request Dec 25, 2024
Closed
@sagihirshfeld sagihirshfeld force-pushed the test-bucket-notifications branch 2 times, most recently from ef07e51 to 206a607 Compare January 6, 2025 16:33
@pull-request-size pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Jan 6, 2025
@sagihirshfeld sagihirshfeld force-pushed the test-bucket-notifications branch 2 times, most recently from 5f40392 to bf68067 Compare January 13, 2025 12:54
@sagihirshfeld sagihirshfeld removed the DO NOT MERGE Do not merge this change!! label Jan 13, 2025
@sagihirshfeld sagihirshfeld changed the title WIP - [4.18] Test MCG bucket notifications - utility functions and happy path validation [4.18] Test MCG bucket notifications - utility functions and happy path validation Jan 13, 2025
@sagihirshfeld sagihirshfeld force-pushed the test-bucket-notifications branch from 8ee95e9 to c47832f Compare January 15, 2025 17:37
ocs-ci
ocs-ci reviewed Jan 15, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_notifications.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

@sagihirshfeld sagihirshfeld force-pushed the test-bucket-notifications branch from c47832f to a1bcdc2 Compare January 16, 2025 00:00
ocs-ci
ocs-ci reviewed Jan 16, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_notifications.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Jan 16, 2025
@sagihirshfeld sagihirshfeld marked this pull request as ready for review January 16, 2025 00:36
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner January 16, 2025 00:36
@sagihirshfeld
Address first review comments
532cf16 
Signed-off-by: Sagi Hirshfeld <[email protected]>
ocs-ci
ocs-ci reviewed Jan 16, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_notifications.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jan 16, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_notifications.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

udaysk23
udaysk23 previously approved these changes Jan 17, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2025
ypersky1980
ypersky1980 previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagihirshfeld
Fix docstrings
d947ebd 
Signed-off-by: Sagi Hirshfeld <[email protected]>
@sagihirshfeld sagihirshfeld dismissed stale reviews from ypersky1980 and udaysk23 via d947ebd January 23, 2025 10:24
@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2025
ypersky1980
ypersky1980 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, mashetty330, sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 4b4b12e into red-hat-storage:master Jan 28, 2025
6 of 7 checks passed
@sagihirshfeld

This comment was marked as resolved.

Sign in to view
@openshift-cherrypick-robot

This comment was marked as resolved.

Sign in to view
@sagihirshfeld

This comment was marked as resolved.

Sign in to view
@openshift-cherrypick-robot

This comment was marked as resolved.

Sign in to view
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@mashetty330 mashetty330 mashetty330 approved these changes

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@keesturam keesturam keesturam approved these changes

@ebenahar ebenahar Awaiting requested review from ebenahar

@udaysk23 udaysk23 Awaiting requested review from udaysk23

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@udaysk23 udaysk23

@ypersky1980 ypersky1980

@mashetty330 mashetty330

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/L PR that changes 100-499 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sagihirshfeld @openshift-cherrypick-robot @keesturam @ocs-ci @udaysk23 @ypersky1980 @mashetty330