Add GRPO on Ray guided example with README#86
Draft
Fiona-Waters wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c2c9e3e to
2bcdd02
Compare
- Add examples/fine-tuning/grpo_ray/ with multi-node distributed GRPO training via CodeFlare SDK RayJob + ManagedClusterConfig - Notebook demonstrates verl backend with FSDP + vLLM across 2 nodes - Update fine-tuning README to include Ray as a fourth execution mode Signed-off-by: Fiona-Waters <fiwaters6@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
2bcdd02 to
d24acc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/fine-tuning/grpo_ray/directory with README and notebookWhat's included
examples/fine-tuning/grpo_ray/README.md— algorithm overview, hardware requirements, GRPO-specific considerations, setup guideexamples/fine-tuning/grpo_ray/grpo_lora-rayjob.ipynb— example notebook: multi-node RayJob submission via CodeFlare SDK, training parameter configuration, reward curve plottingexamples/fine-tuning/README.md— updated to list Ray as an execution modeDetails
lora_grpo()with the verl backend (FSDP + vLLM) distributed across 2 nodes (4 GPUs total)RayJob+ManagedClusterConfigDependencies
RayJob+ManagedClusterConfigsupportTODO
Related Tickets
Related jira tickets here:
How Has This Been Tested?
TODO - Run notebook manually on an openshift cluster
Checklist