Skip to content

Add GPU debugging output to workbench example#5

Open
ktdreyer wants to merge 1 commit into
red-hat-data-services:mainfrom
ktdreyer:add-gpu-debugging-info
Open

Add GPU debugging output to workbench example#5
ktdreyer wants to merge 1 commit into
red-hat-data-services:mainfrom
ktdreyer:add-gpu-debugging-info

Conversation

@ktdreyer
Copy link
Copy Markdown

@ktdreyer ktdreyer commented Sep 12, 2025

Add GPU debugging information to the llmcompressor workbench example notebook to help users understand whether GPU acceleration is available.

This enhancement helps users verify that their GPU setup is working correctly and understand why they might be experiencing slower performance or abbreviated datasets.

Fixes #4

@ktdreyer ktdreyer force-pushed the add-gpu-debugging-info branch from 01f4d79 to 3c6ef67 Compare September 12, 2025 18:20
@ktdreyer ktdreyer force-pushed the add-gpu-debugging-info branch from 3c6ef67 to 3b47208 Compare September 12, 2025 18:55
@ktdreyer
Copy link
Copy Markdown
Author

I don't know the proper way to test in ODH (yet), so I tested this on a bare g6e.4xlarge AWS CentOS node like so:

  1. SSH to the node with port-forwarding:
    ssh -L 8888:localhost:8888 ec2-user@ec2-1-2-3-4.us-east-2.compute.amazonaws.com
  2. Run the Jupyter image:
    podman run -p 8888:8888 --privileged -it --rm --gpus all quay.io/opendatahub/llmcompressor-workbench:main
    
  3. Log into http://localhost:8888/lab
  4. Import the workbench from my fork (workbench_example.ipynb)

@jiridanek
Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f6a9fa3-8355-433e-8b3c-11d1cbb3ff76

📥 Commits

Reviewing files that changed from the base of the PR and between 37af793 and 3b47208.

📒 Files selected for processing (1)
  • examples/llmcompressor/workbench_example.ipynb

📝 Walkthrough

Walkthrough

Adds GPU-availability messaging to a Jupyter notebook by printing GPU status after checking torch.cuda.is_available(). If no GPU is available, a CPU-only mode warning is printed for user debugging purposes.

Changes

Cohort / File(s) Summary
GPU Debugging Output
examples/llmcompressor/workbench_example.ipynb
Adds conditional print statements to display GPU availability status and CPU-only mode warning when GPU is not detected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding GPU debugging output to the workbench example notebook.
Description check ✅ Passed The description is clearly related to the changeset, explaining the purpose of adding GPU debugging information and referencing the linked issue.
Linked Issues check ✅ Passed The PR fully addresses issue #4 by adding GPU debugging output to the workbench example notebook as requested.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of adding GPU debugging information to the workbench example notebook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Ruff (0.15.5)
examples/llmcompressor/workbench_example.ipynb

Unexpected end of JSON input


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add GPU debugging information for llmcompressor/workbench_example.ipynb

2 participants