Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModelID update from Trusty as Model name is the model id now #1783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nehachopra27
Copy link
Contributor

Earlier the model id was updated by the TrustyAI service. Now the operator doesn't make any changes. So removing the unnecessary model id check now.

Also edit the pod numbers to 1.

Copy link

sonarqubecloud bot commented Sep 5, 2024

${modelId} Replace String ${modelId} " ${EMPTY}
Schedule Bias Metrics request via CLI metricsType=dir modelId=${modelId} token=${token} protectedAttribute="customer_data_input-3"
... favorableOutcome=0 outcomeName="predict" privilegedAttribute=1.0 unprivilegedAttribute=0.0
Schedule Bias Metrics request via CLI metricsType=dir modelId=${MODEL_ALPHA} token=${token}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Schedule Bias Metrics request via CLI' does not follow case convention
${modelId} Replace String ${modelId} " ${EMPTY}
Schedule Bias Metrics request via CLI metricsType=spd modelId=${modelId} token=${token} protectedAttribute="customer_data_input-3"
... favorableOutcome=0 outcomeName="predict" privilegedAttribute=1.0 unprivilegedAttribute=0.0
Schedule Bias Metrics request via CLI metricsType=spd modelId=${MODEL_BETA} token=${token}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Schedule Bias Metrics request via CLI' does not follow case convention
... favorableOutcome=0 outcomeName="predict" privilegedAttribute=1.0 unprivilegedAttribute=0.0
Schedule Bias Metrics request via CLI metricsType=spd modelId=${MODEL_BETA} token=${token}
... protectedAttribute="customer_data_input-3" favorableOutcome=0 outcomeName="predict"
... privilegedAttribute=1.0 unprivilegedAttribute=0.0 trusty_route=${TRUSTY_ROUTE}

Check warning

Code scanning / Robocop

Each next continuation line should be aligned with the previous one Warning test

Each next continuation line should be aligned with the previous one
Schedule Bias Metrics request via CLI
[Documentation] Schedule a SPD or DIR metrics via CLI
[Arguments] ${metricsType} ${modelId} ${protectedAttribute} ${favorableOutcome} ${outcomeName}
... ${privilegedAttribute} ${unprivilegedAttribute} ${token}
${curl_cmd}= Set Variable curl -k -H "Authorization: Bearer ${token}" ${TRUSTY_ROUTE}/metrics/${metricsType}/request --header
... ${privilegedAttribute} ${unprivilegedAttribute} ${token} ${trusty_route}

Check notice

Code scanning / Robocop

There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test

There is too many arguments per continuation line (4 / 1)
... ${privilegedAttribute} ${unprivilegedAttribute} ${token}
${curl_cmd}= Set Variable curl -k -H "Authorization: Bearer ${token}" ${TRUSTY_ROUTE}/metrics/${metricsType}/request --header
... ${privilegedAttribute} ${unprivilegedAttribute} ${token} ${trusty_route}
${curl_cmd}= Set Variable curl -k -H "Authorization: Bearer ${token}" ${trusty_route}/metrics/${metricsType}/request --header

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
533 0 0 533 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants