Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Authentication overlay odh-dashboard #444

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update Authentication overlay odh-dashboard #444

wants to merge 1 commit into from

Conversation

VaishnaviHire
Copy link

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s):
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

@VaishnaviHire VaishnaviHire requested review from etirelli and zdtsw July 31, 2023 21:17
@VaishnaviHire VaishnaviHire force-pushed the update_authentication_dashboard branch from 9981b4d to cc0ad43 Compare July 31, 2023 21:22
etirelli
etirelli approved these changes Jul 31, 2023
View reviewed changes
Copy link

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VaishnaviHire
Copy link
Author

/hold

Need to test with existing RHODS installation

zdtsw
zdtsw approved these changes Aug 1, 2023
View reviewed changes
Copy link

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucferbux
Copy link

@VaishnaviHire I think based on what we've investigating this will break the release 😅
I'm preparing a PR trying to sync odh-manifest with upstream let me include this.

@zdtsw
Copy link

zdtsw commented Sep 5, 2023

should we close this one , in favor of #446 ?

@lucferbux
Copy link

should we close this one , in favor of #446 ?

Yes, as long as we are still supporting the old operator we need to hold

@zdtsw zdtsw marked this pull request as draft September 25, 2023 07:27
@zdtsw
Copy link

zdtsw commented Jan 29, 2024

can close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@etirelli etirelli etirelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VaishnaviHire @lucferbux @zdtsw @etirelli