Repository navigation
fix: Restore namespace discovery label on FeatureStore reconcile - #347
Merged
jyejare merged 1 commit intoSep 3, 2026
Conversation
The operator is documented to add `opendatahub.io/feast: "true"` to any namespace holding a deployed FeatureStore, so dashboards can discover Feast namespaces cluster-wide via that label selector. The reconcile wiring for it was dropped during an upstream merge, leaving access.EnsureNamespaceLabel and access.RemoveNamespaceLabelIfLast orphaned while the manager-role kept the now-unused `namespaces: update` permission. Wire both back into Reconcile: - Add the label in the post-deploy block, gated on the Ready condition, so it lands only after the FeatureStore is actually deployed. - Remove it on both deletion paths (CR-not-found and DeletionTimestamp set), and only when no other live FeatureStore remains in the namespace. - Run the removal before the namespace-registry and OpenLineage cleanups, which return early on error and would otherwise strand the label. countOtherFeatureStoresInNamespace returns (int, error) so a List failure keeps the label in place, rather than the -1 sentinel used elsewhere which fails the `> 0` check and unlabels the namespace on any transient API error. Regenerated with `make manifests generate bundle`, which produced no manifest changes: the marker already granted `core/namespaces: get;list;watch;update`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
jyejare
approved these changes
Sep 3, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator is documented to add
opendatahub.io/feast: "true"to any namespace holding a deployed FeatureStore, so dashboards can discover Feast namespaces cluster-wide via that label selector. The reconcile wiring for it was dropped during an upstream merge, leaving access.EnsureNamespaceLabel and access.RemoveNamespaceLabelIfLast orphaned while the manager-role kept the now-unusednamespaces: updatepermission.Wire both back into Reconcile:
countOtherFeatureStoresInNamespace returns (int, error) so a List failure keeps the label in place, rather than the -1 sentinel used elsewhere which fails the
> 0check and unlabels the namespace on any transient API error.Regenerated with
make manifests generate bundle, which produced no manifest changes: the marker already grantedcore/namespaces: get;list;watch;update.What this PR does / why we need it:
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc