Skip to content

Commit

Permalink
Merge pull request #536 from rechsteiner/access-modifiers
Browse files Browse the repository at this point in the history
Make PageViewControllerDataSource/Delegate methods open
  • Loading branch information
rechsteiner authored Dec 3, 2020
2 parents a44d39e + 6aa76d3 commit 5edccdd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Parchment/Classes/PagingViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ open class PagingViewController:

// MARK: PageViewControllerDataSource

public func pageViewController(_ pageViewController: PageViewController, viewControllerBeforeViewController viewController: UIViewController) -> UIViewController? {
open func pageViewController(_ pageViewController: PageViewController, viewControllerBeforeViewController viewController: UIViewController) -> UIViewController? {
guard
let dataSource = infiniteDataSource,
let currentPagingItem = state.currentPagingItem,
Expand All @@ -647,7 +647,7 @@ open class PagingViewController:
return dataSource.pagingViewController(self, viewControllerFor: pagingItem)
}

public func pageViewController(_ pageViewController: PageViewController, viewControllerAfterViewController viewController: UIViewController) -> UIViewController? {
open func pageViewController(_ pageViewController: PageViewController, viewControllerAfterViewController viewController: UIViewController) -> UIViewController? {
guard
let dataSource = infiniteDataSource,
let currentPagingItem = state.currentPagingItem,
Expand All @@ -658,7 +658,7 @@ open class PagingViewController:

// MARK: PageViewControllerDelegate

public func pageViewController(_ pageViewController: PageViewController, isScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController?, progress: CGFloat) {
open func pageViewController(_ pageViewController: PageViewController, isScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController?, progress: CGFloat) {
guard let currentPagingItem = state.currentPagingItem else { return }

pagingController.contentScrolled(progress: progress)
Expand All @@ -671,7 +671,7 @@ open class PagingViewController:
progress: progress)
}

public func pageViewController(_ pageViewController: PageViewController, willStartScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController) {
open func pageViewController(_ pageViewController: PageViewController, willStartScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController) {
if let upcomingPagingItem = state.upcomingPagingItem {
delegate?.pagingViewController(
self,
Expand All @@ -681,7 +681,7 @@ open class PagingViewController:
}
}

public func pageViewController(_ pageViewController: PageViewController, didFinishScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController, transitionSuccessful: Bool) {
open func pageViewController(_ pageViewController: PageViewController, didFinishScrollingFrom startingViewController: UIViewController, destinationViewController: UIViewController, transitionSuccessful: Bool) {
if transitionSuccessful {
pagingController.contentFinishedScrolling()
}
Expand Down

0 comments on commit 5edccdd

Please sign in to comment.