Fix invalid urls #3041
Merged
Fix invalid urls #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yminsky
reviewed
Dec 19, 2018
| @@ -249,7 +249,7 @@ the language and about libraries tools and techniques that will help you be a | |||
| more effective OCaml programmer. But it's no replacement for API | |||
| documentation or the OCaml manual and man pages. You can find documentation | |||
| for all of the libraries and tools referenced in the book | |||
| [online](https://realworldocaml.org/doc). | |||
| [online](https://ocaml.janestreet.com/ocaml-core/). | |||
There was a problem hiding this comment.
@avsm: what do you think about this? Pointing at the JS docs seems wrong, since there are other libraries we use in RWO. Maybe that's OK as a temporary move, but we should really get docs generated for the RWO libraries specifically...
There was a problem hiding this comment.
I'll take a look at generating the docs ourselves. I'm very close to having a full "rwo duniverse" working as the last difficult library to port is en route now with yallop/ocaml-ctypes#588
Once that's done, the docs are as simple as a dune build @doc from a cronjob.
I'll merge this particular PR now as the current URL is wrong, and update it when those docs are live. Thanks for this PR @colin4124!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.