Skip to content

Conversation

acsany
Copy link
Contributor

@acsany acsany commented Aug 12, 2025

@acsany
Copy link
Contributor Author

acsany commented Aug 12, 2025

@martin-martin I'm currently struggling a little bit with the linter. My local ruff (same version as the CI/CD) is happy with the formatting:

CleanShot_2025-08-12_16-15-45@2x

Personally, I'd add the fastapi imports before the jinja2 and pydantic ones, but it seems ruff has a different opinion on that. Maybe you have a suggestion on how to fix the linter error?

@acsany acsany requested a review from martin-martin August 12, 2025 14:18
@martin-martin
Copy link
Contributor

@acsany it's usually a version mismatch between your local linting tools and the ones that the CI uses. The ones here on the materials repo are kind of old:

black[jupyter]==24.4.2
ruff==0.4.2

I've just set it up locally for me with the old versions, ran the lint check, and ruff did the fix for me that old man ruff expected (adding a newline between pydantic and fastapi. They needed some space to think...)

Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, a couple of small syncing changes and we're good to go 🚀

@martin-martin martin-martin self-requested a review October 8, 2025 11:34
Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants