-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add Materials for "A Close Look at a FastAPI Example Application" #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@martin-martin I'm currently struggling a little bit with the linter. My local ruff (same version as the CI/CD) is happy with the formatting: ![]() Personally, I'd add the |
@acsany it's usually a version mismatch between your local linting tools and the ones that the CI uses. The ones here on the materials repo are kind of old:
I've just set it up locally for me with the old versions, ran the lint check, and ruff did the fix for me that old man ruff expected (adding a newline between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, a couple of small syncing changes and we're good to go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trello: https://trello.com/c/0QkmGHJA/1367-using-fastapi-to-build-python-web-apis-update