Add slimmed-down Selenium project code #596
Conversation
|
@bzaczynski this is my attempt to create a slimmed-down version of the project that primarily focuses on Selenium web interactions (now following POM), but also keep the basic functionality of the music player (and a reduced---but existing---separation of concerns). I've tried to build the project in a way so that it can lead into the project that you wrote, with the idea in mind that learners could follow your SbSP as a next step if they're interested in the music player project. At the same time, I tried to keep it simple and reduced enough that learners who are only there for an intro to Selenium would get their money's worth. Hope this works and looking forward to your thoughts! Linking the other PR for reference: #583 |
There was a problem hiding this comment.
@martin-martin I left a few comments for you. Let me know what you think.
There was a problem hiding this comment.
@martin-martin Perfecto ✨ Thanks for a quick update! Can't wait to review the rest of it 😉
Bandcamp removed the "Discover" section from their main page since we wrote this code. Now, the tracks are only available at the dedicated /discover URL. I restructured the code to target the /discover site instead, which required a couple of changes. Still, the existing POM structure was helpful :) I also (re)introduced a new "pause" option, because that's a bit easier in this new structure. Finally, I only allow loading more songs once, which gives a total of 120 songs to pick from with the default screen setting. Attempting to load more resulted in errors, I think because they'd be outside of the viewport and I didn't want to expand the code more and introduce scrolling more of them into view. Also, not sure whether that'd take earlier ones out of the viewport (etc) so I just decided not to open that can of worms for this "Intro to Selenium" tutorial. LMK if you disagree, otherwise of course you can tackle that in your longer one that builds on top of this one :)
Co-authored-by: Bartosz <[email protected]>
There was a problem hiding this comment.
@martin-martin Hi Martin!
The code looks great overall. I only left a few minor comments for your consideration, but no explicit requests for change.
Take care!
Where to put new files:
my-awesome-articleHow to merge your changes: