Dont use kotlin reflection (#1544) #1851
Conversation
|
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @kzotin. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
|
PS. I've submitted the CLA form yesterday |
|
@cla-bot check |
|
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @kzotin. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
clementetb
added
the
no-jira-ticket
|
Would you mind adding a changelog entry to the PR? |
|
Updated the changelog |
| } | ||
|
|
||
| return companion | ||
| } |
There was a problem hiding this comment.
We tested this fix in our project. The fix makes realm configuration creating much faster, but it slows down some queries. If realmObjectCompanionOrNull called with Double::class then this function works much slower (more than on 50%). Most likely because of Class.forName() is called two times on every realmObjectCompanionOrNull function call.
There was a problem hiding this comment.
Double::class implements Parcelable in your case?) Twice call can be only for classes that implements Parcelable and only once when warm up the cache
This should fix realm#1544 See this PR that was the inspiration: realm#1851
This should fix realm#1544 See this PR that was the inspiration: realm#1851
This should fix realm#1544 See this PR that was the inspiration: realm#1851
|
Hello, thanks to https://github.com/XilinJia/krdb, we published a fork on Maven Central yesterday, supporting all targets (iOS and macOS included), and we included a fix for this issue. https://github.com/Infomaniak/realm-kotlin/releases/tag/3.2.8-2 |
7 participants
Kotlin reflection is super slow on some old devices (~20seconds on cold start, see #1544 ), which is a blocker for us after migrating from realm-java to kotlin.
We've got such device, and fix was verified there