Skip to content

Conversation

@nandhinisubbu
Copy link
Contributor

Enhancement - #6167

@SwiftLintBot
Copy link

SwiftLintBot commented Oct 17, 2025

15530 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/FiltersViewController.swift:67:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/FiltersViewController.swift:69:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:159:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:161:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:336:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:338:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsUpdates.swift:38:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsUpdates.swift:40:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:75:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:77:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:213:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:215:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:261:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:263:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:265:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:390:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:392:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:401:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:403:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:405:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:407:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:409:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:411:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:413:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:415:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:417:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:419:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:65:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:67:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:145:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:147:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:265:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:267:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:269:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:271:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:273:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:275:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:277:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:279:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:281:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:283:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:285:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:287:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:289:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:291:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:293:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:295:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:297:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:299:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:301:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:303:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:311:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:313:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:315:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:317:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:319:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:321:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:323:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:325:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:327:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:329:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:331:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:333:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:335:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:337:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:339:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:341:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:343:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:345:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:347:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:349:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/PlaybackSpeed.swift:14:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/PlaybackSpeed.swift:16:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:256:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:258:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:23:21: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:24:22: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:25:23: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:26:23: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:27:22: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:149:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:151:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:153:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:155:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:157:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:60:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:62:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:64:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:67:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:69:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:71:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:73:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:76:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:78:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:80:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:82:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:84:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:86:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:89:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:92:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:95:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:98:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:101:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:104:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:106:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:108:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:110:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:112:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:114:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:116:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:118:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:120:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:123:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:125:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:127:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:130:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:134:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:113:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:115:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:167:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:169:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:191:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:194:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:203:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:205:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:207:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:209:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:211:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:213:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:215:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:217:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:219:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:221:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:309:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:311:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:317:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:319:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:58:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:60:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:81:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:83:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:85:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:87:13: Warning: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ Danger found 15530 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 144.
18 Messages
📖 Building this branch resulted in a binary size of 26258.12 KiB vs 26239.95 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.8 s vs 0.79 s on main (1% slower).
📖 Linting Alamofire with this PR took 1.04 s vs 1.05 s on main (0% faster).
📖 Linting Brave with this PR took 6.83 s vs 6.87 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 21.5 s vs 21.55 s on main (0% faster).
📖 Linting Firefox with this PR took 10.79 s vs 10.78 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.57 s vs 7.59 s on main (0% faster).
📖 Linting Moya with this PR took 0.44 s vs 0.44 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 2.4 s vs 2.38 s on main (0% slower).
📖 Linting Nimble with this PR took 0.6 s vs 0.65 s on main (7% faster).
📖 Linting PocketCasts with this PR took 6.83 s vs 6.71 s on main (1% slower).
📖 Linting Quick with this PR took 0.41 s vs 0.41 s on main (0% slower).
📖 Linting Realm with this PR took 3.28 s vs 3.3 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.85 s vs 1.86 s on main (0% faster).
📖 Linting Swift with this PR took 4.21 s vs 4.21 s on main (0% slower).
📖 Linting VLC with this PR took 1.15 s vs 1.14 s on main (0% slower).
📖 Linting Wire with this PR took 17.3 s vs 17.36 s on main (0% faster).
📖 Linting WordPress with this PR took 11.36 s vs 11.34 s on main (0% slower).

Generated by 🚫 Danger

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool. Thanks @nandhinisubbu!

Logically, this looks about right. Did you consider if expressions as the only statements in switch cases and vice versa? I think, there should be some kind of recursion to cover that.

With respect to code structure, I'd add all the functions with a single syntax node argument as computed properties to the syntax node itself. That also separates them a little from the rule's implementation, so that the visitor as the entry point is rather small and only provides the entry points.

Other than that, we should probably make checking of if and switch expression optional. I can imagine, not everyone wants to have them checked. Then, for SwiftLint itself, keep the option off and enable to only in a follow-up PR to separate the concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants