Add legacy_uigraphics_functions rule
#6269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
SimplyDanny
requested changes
Oct 2, 2025
Comment on lines
+31
to
+33
| * Add `legacy_uigraphics_functions` rule to encourage the use of modern | ||
| UIGraphicsImageRenderer instead of legacy UIGraphics{Begin|End}ImageContext. | ||
| The modern replacement is safer, cleaner, Retina-aware and more performant. |
There was a problem hiding this comment.
Suggested change
| * Add `legacy_uigraphics_functions` rule to encourage the use of modern | |
| UIGraphicsImageRenderer instead of legacy UIGraphics{Begin|End}ImageContext. | |
| The modern replacement is safer, cleaner, Retina-aware and more performant. | |
| * Add `legacy_uigraphics_functions` rule to encourage the use of modern | |
| `UIGraphicsImageRenderer `instead of legacy `UIGraphics{Begin|End}ImageContext`. | |
| The modern replacement is safer, cleaner, Retina-aware and more performant. |
| @@ -0,0 +1,82 @@ | |||
| import SwiftSyntax | |||
|
|
|||
| @SwiftSyntaxRule | |||
There was a problem hiding this comment.
The rule should be opt-in as you have described in the issue:
Suggested change
| @SwiftSyntaxRule | |
| @SwiftSyntaxRule(optIn: true) |
| kind: .idiomatic, | ||
| nonTriggeringExamples: [ | ||
| Example(""" | ||
| let renderer = UIGraphicsImageRenderer(size: bounds.size) |
There was a problem hiding this comment.
Tests can be a bit easier, as the rule effectively only checks function names. So the let screenshot = ... part isn't actually necessary.
|
I wasn't actually aware of Edit: I remove the helper in #6271 so that visitor and rewrite can directly be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
legacy_uigraphics_functionsrule to encourage the use of modern UIGraphicsImageRenderer instead of legacy UIGraphics{Begin|End}ImageContext.The modern replacement is safer, cleaner, Retina-aware and more performant.
The legacy API is deprecated
Resolves #6268