Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support: top-trace with some file exporters #5

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

support: top-trace with some file exporters #5

wants to merge 9 commits into from

Conversation

v1v
Copy link
Collaborator

@v1v v1v commented Jun 18, 2024 •
edited
Loading

I can now see logs in the terminal and in the /tmp/logs.txt file:

2024-06-18T18:29:09.025+0200	debug	[email protected]/trace_test_handling.go:34	Creating root parent span	{"kind": "receiver", "name": "githubactionsjunit", "data_type": "traces", "name": "ci"}
2024-06-18T18:29:09.025+0200	debug	[email protected]/receiver.go:160	Unmarshaled spans	{"kind": "receiver", "name": "githubactionsjunit", "data_type": "traces", "#spans": 1}
2024-06-18T18:29:09.194+0200	info	TracesExporter	{"kind": "exporter", "data_type": "traces", "name": "debug", "resource spans": 11, "spans": 11}
2024-06-18T18:29:09.396+0200	info	TracesExporter	{"kind": "exporter", "data_type": "traces", "name": "debug", "resource spans": 8, "spans": 8}

Supersedes #4

Tasks

  • Support suites traces
  • Support tests
  • Support attributes from the suites to the tests
  • [ ]

v1v
v1v commented Jun 18, 2024
View reviewed changes
receiver.go
@@ -175,55 +193,6 @@ func processJunitFile(file *zip.File, logger *zap.Logger) []junit.Suite {
return suites
}

func processSuite(suite junit.Suite, logger *zap.Logger) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more debugging

trace_attributes.go
@@ -0,0 +1,101 @@
package opentelemetrygithubactionsjunitreceiver
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centrallise all the attributes for the GitHub workflow events and the Test Suites/Test Cases

trace_test_handling.go Outdated

createParentSpan(scopeSpans, suite, e, traceID, logger)

// TODO: create child spans for each test case
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next big thing... support iterating over all the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @reakaleek