-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: react 19 ftw #7329
Open
harish-sethuraman
wants to merge
3
commits into
main
Choose a base branch
from
react-19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: react 19 ftw #7329
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ import {MDXComponents} from 'components/MDX/MDXComponents'; | |
|
||
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
// ~~~~ IMPORTANT: BUMP THIS IF YOU CHANGE ANY CODE BELOW ~~~ | ||
const DISK_CACHE_BREAKER = 9; | ||
const DISK_CACHE_BREAKER = 11; | ||
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
export default async function compileMDX( | ||
|
@@ -36,13 +36,13 @@ export default async function compileMDX( | |
lockfile: fs.readFileSync(process.cwd() + '/yarn.lock', 'utf8'), | ||
}) | ||
); | ||
const cached = await store.get(hash); | ||
if (cached) { | ||
console.log( | ||
'Reading compiled MDX for /' + path + ' from ./node_modules/.cache/' | ||
); | ||
return cached; | ||
} | ||
// const cached = await store.get(hash); | ||
// if (cached) { | ||
// console.log( | ||
// 'Reading compiled MDX for /' + path + ' from ./node_modules/.cache/' | ||
// ); | ||
// return cached; | ||
// } | ||
if (process.env.NODE_ENV === 'production') { | ||
console.log( | ||
'Cache miss for MDX for /' + path + ' from ./node_modules/.cache/' | ||
|
@@ -60,13 +60,15 @@ export default async function compileMDX( | |
.join('\n'); | ||
|
||
// Turn the MDX we just read into some JS we can execute. | ||
const {remarkPlugins} = require('../../plugins/markdownToHtml'); | ||
// const {remarkPlugins} = require('../../plugins/markdownToHtml'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check why we aren't able to use remark / rehype plugins after upgrading it. getting
|
||
const {compile: compileMdx} = await import('@mdx-js/mdx'); | ||
const visit = (await import('unist-util-visit')).default; | ||
const jsxCode = await compileMdx(mdxWithFakeImports, { | ||
remarkPlugins: [ | ||
...remarkPlugins, | ||
(await import('remark-gfm')).default, | ||
// ...remarkPlugins, | ||
( | ||
await import('remark-gfm') | ||
).default, | ||
(await import('remark-frontmatter')).default, | ||
], | ||
rehypePlugins: [ | ||
|
@@ -144,7 +146,10 @@ export default async function compileMDX( | |
|
||
// Serialize a server React tree node to JSON. | ||
function stringifyNodeOnServer(key: unknown, val: any) { | ||
if (val != null && val.$$typeof === Symbol.for('react.element')) { | ||
if ( | ||
val != null && | ||
val.$$typeof === Symbol.for('react.transitional.element') | ||
) { | ||
// Remove fake MDX props. | ||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
const {mdxType, originalType, parentName, ...cleanProps} = val.props; | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now removed caching re enable before we push it to main