Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/errors: Empty args are not missing arguments #6767

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 20, 2024

e.g. the hydration diff will always produce /errors/418?args[]= in prod because prod doesn't have diffs. This displayed a [missing-argument] which isn't accurate.

Includes drive-by fix for #6734

Preview:

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:53am
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:53am

Copy link

github-actions bot commented Apr 20, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 105.96 KB (-4 B) 210.34 KB
/500 105.96 KB (-4 B) 210.33 KB
/[[...markdownPath]] 107.75 KB (-4 B) 212.12 KB
/errors 106.17 KB (-4 B) 210.55 KB
/errors/[errorCode] 106.15 KB (-4 B) 210.53 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@eps1lon eps1lon marked this pull request as ready for review April 20, 2024 20:07
@eps1lon eps1lon requested a review from rickhanlonii April 20, 2024 20:07
e.g. the hydration diff will always produce `/errors/418?args[]=` in prod because prod doesn't have diffs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No new lines in error decoder errors
2 participants