Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide quick summary of dependencies array in useEffect #6437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianlove
Copy link

Provide a clearer, up-front explanation of the three cases for the dependencies parameter in useEffect to reduce the need to click through to the more in-depth explanation further down. I often find myself needing to follow the 'See the differences...' link just to be reminded of which situation to provide an empty array vs no array. Providing these details right up front streamlines that process, with minimal impacts to the rest of the documentation.

Provide a clearer, up-front explanation of the three cases for the
`dependencies` parameter in `useEffect` to reduce the need to click
through to the more in-depth explanation further down.  I often find
myself needing to follow the 'See the differences...' link just to be
reminded of which situation to provide an empty array vs no array.
Providing these details right up front streamlines that process, with
minimal impacts to the rest of the documentation.
@facebook-github-bot
Copy link
Collaborator

Hi @brianlove!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants