Fixes related to "Your UI as a Tree" #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
smikitky
force-pushed
the
ui-tree-fixes
branch
from
484ef84 to
a7fab53
Compare
|
Thanks for the fixes, re: your 3rd point, I can see what you mean about graph vs. tree but I'd say the concept of a module dependency tree I'm trying to convey here is the module usage vs. the entity of the module. Happy to hear suggestions of how to clarify that given how we're explaining the concept of 'use client' |
lunaleaps
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains four small corrections related to the recently added "Your UI as a Tree" article.
<Diagram>tag with other articles. This isn't just an issue with the source file; this also inserts a<p>tag within the<figcaption>, improving visual consistency.As far as I can remember, the concept of "module dependency tree" has previously been referred to as "module graph" in the new React docs. For consistency, I modified the term "module graph" in a past article and added an appropriate link. The same phrase appears in this page, but I have left it unchanged since it's a blog article.Sorry I wasn't aware of 'use client' - flesh out usages and reference #6362By the way, I understand why a render tree is called a tree, but is a module dependency tree really a tree? Since exactly the same module can be referenced from multiple modules, I wonder if technically "graph" would be a more accurate term in this case...