Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using strict equality in the JS example for City Quiz #6373

Merged
merged 1 commit into from Oct 26, 2023
Merged

Using strict equality in the JS example for City Quiz #6373

merged 1 commit into from Oct 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2023

Description:

This PR addresses the issue where the quiz answer is verified using loose equality. You can find this in the very first sandbox example used (City Quiz) in the "Learn React" -> "Managing State" -> "Reacting to Input with State" section of the documentation.

image

Review:

The updated code uses the strict equality operator (===) for comparison.

Overall Assessment:

Based on the review, the use of the strict equality operator is a good practice in JavaScript and should be implemented in the code. However, please address the checklist items and any comments before this PR can be approved.

@facebook-github-bot
Copy link
Collaborator

Hi @nigupta29!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@sophiebits sophiebits merged commit 76c1bde into reactjs:main Oct 26, 2023
3 checks passed
@sophiebits
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants