refac: Search component type improvements #6370
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the type of
Hit
type in the Search component.Instead of being of type
any
, it is now of typeprops
of the actualhitComponent
ofDocSearchProps
.https://github.com/algolia/docsearch/blob/main/packages/docsearch-react/src/DocSearch.tsx#L26
The type of
url
isstring
.https://github.com/algolia/docsearch/blob/main/packages/docsearch-react/src/types/DocSearchHit.ts#L45
hit.url.replace()
,hit.url
will return the same result. However,replace()
throws a type error because it actually needs to take2 arguments
, so only hit.url is sufficient.