Remove unsupported ga-lite and update existing calls to GA4 #6366
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
| const terminationEvent = 'onpagehide' in window ? 'pagehide' : 'unload'; | ||
| window.addEventListener(terminationEvent, function () { | ||
| ga('send', 'timing', 'JS Dependencies', 'unload'); | ||
| // @ts-ignore |
There was a problem hiding this comment.
can you install the gtag typescript typtes instead of a ts-ignore here? I think yarn add @types/gtag.js --dev should do the trick.
There was a problem hiding this comment.
Oh nice! I can follow up and add this in a separate PR
|
|
||
| import '@docsearch/css'; | ||
| import '../styles/algolia.css'; | ||
| import '../styles/index.css'; | ||
| import '../styles/sandpack.css'; | ||
|
|
||
| if (typeof window !== 'undefined') { | ||
| if (process.env.NODE_ENV === 'production') { |
There was a problem hiding this comment.
Why was this check removed? Does this mean that PR preview deploys and locally hosted environments will now send GA4 events?
There was a problem hiding this comment.
This check was for the two deprecated ga calls that were also removed so it's no longer needed
We recently updated our GA tag to include GA4 in this PR
These changes removes the no longer used
ga-lite, and updates it to usegtaginstead sincega-liteis no longer supported.I've also updated
NEXT_PUBLIC_GA_TRACKING_IDto the new ID, and removed it fromsrc/siteConfig.jsTest plan