Skip to content

Wrap NODE_ENV conditional code in block to remove dead code #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Wrap NODE_ENV conditional code in block to remove dead code #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4cf5b1
Wrap NODE_ENV conditional code in block
vlazh Oct 26, 2021
38034f0
Wrap NODE_ENV conditional code in block
vlazh Oct 26, 2021
3f416da
Wrap NODE_ENV conditional code in block
vlazh Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/helpers/ariaAppHider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ export function resetState() {

/* istanbul ignore next */
export function log() {
if (process.env.NODE_ENV === "production") return;
const check = globalElement || {};
console.log("ariaAppHider ----------");
console.log(check.nodeName, check.className, check.id);
console.log("end ariaAppHider ----------");
if (process.env.NODE_ENV !== "production") {
var check = globalElement || {};
console.log("ariaAppHider ----------");
console.log(check.nodeName, check.className, check.id);
console.log("end ariaAppHider ----------");
}
}
/* eslint-enable no-console */

Expand Down
38 changes: 19 additions & 19 deletions src/helpers/classList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,30 @@ export function resetState() {

/* istanbul ignore next */
export function log() {
if (process.env.NODE_ENV === "production") return;
if (process.env.NODE_ENV !== "production") {
let classes = document.getElementsByTagName("html")[0].className;
let buffer = "Show tracked classes:\n\n";

let classes = document.getElementsByTagName("html")[0].className;
let buffer = "Show tracked classes:\n\n";
buffer += `<html /> (${classes}):
`;
for (let x in htmlClassList) {
buffer += ` ${x} ${htmlClassList[x]}
`;
}

buffer += `<html /> (${classes}):
`;
for (let x in htmlClassList) {
buffer += ` ${x} ${htmlClassList[x]}
`;
}

classes = document.body.className;
classes = document.body.className;

buffer += `\n\ndoc.body (${classes}):
`;
for (let x in docBodyClassList) {
buffer += ` ${x} ${docBodyClassList[x]}
`;
}
buffer += `\n\ndoc.body (${classes}):
`;
for (let x in docBodyClassList) {
buffer += ` ${x} ${docBodyClassList[x]}
`;
}

buffer += "\n";
buffer += "\n";

console.log(buffer);
console.log(buffer);
}
}
/* eslint-enable no-console */

Expand Down
15 changes: 8 additions & 7 deletions src/helpers/focusManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ export function resetState() {

/* istanbul ignore next */
export function log() {
if (process.env.NODE_ENV === "production") return;
console.log("focusManager ----------");
focusLaterElements.forEach(f => {
const check = f || {};
console.log(check.nodeName, check.className, check.id);
});
console.log("end focusManager ----------");
if (process.env.NODE_ENV !== "production") {
console.log("focusManager ----------");
focusLaterElements.forEach(f => {
const check = f || {};
console.log(check.nodeName, check.className, check.id);
});
console.log("end focusManager ----------");
}
}
/* eslint-enable no-console */

Expand Down