Changelog writer. #565
Merged
Changelog writer. #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasbruno
force-pushed
the
fix/changelog-writer
branch
2 times, most recently
from
2c30f60 to
61e9409
Compare
|
Changes Unknown when pulling 61e9409 on diasbruno:fix/changelog-writer into ** on reactjs:master**. |
diasbruno
force-pushed
the
fix/changelog-writer
branch
from
61e9409 to
f5dd944
Compare
now we avoid the RCs and Alpha version, so they won't appear on the log. also, now we negate the log entries that are related to releases using a filter, which is better than exclude the first entry using Changelog::log_in_between_versions (that way, sometimes we remove a valid entry).
diasbruno
force-pushed
the
fix/changelog-writer
branch
from
f5dd944 to
92065af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we avoid the RCs and Alpha version, so they won't appear on the
log.
Also, now we negate the log entries that are related to releases
using a filter, which is better than exclude the first entry
using Changelog::log_in_between_versions (that way, sometimes we
remove a valid entry).
Changes proposed:
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md.