-
Notifications
You must be signed in to change notification settings - Fork 812
[chore] upgrade React devDeps to 15.6 #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has some changes that are out of the scope, but refactoring is always a good thing.
Some of the changes makes lines longer. You can move some of the expect(CHECK)
to a variable, like:
const check = ...;
expect(check).toBe(...);
jsx syntax
is better to read if they have their own line, and, sometimes, wrapped with ()
, so any editor can indent better/correct. Example:
ReactDOM.render((
<Modal isOpen appElement={el} />
), node);
specs/helper.js
Outdated
(element, opts) => | ||
eventCtor( | ||
element, | ||
Object.assign( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, we can use ...
operator instead of Object.assign
.
specs/helper.js
Outdated
key: key, | ||
keyCode: code, | ||
which: code | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, we can use { key, keyCode: code, which: code }
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...or change the code
on the arguments to keyCode
.
{ key, keyCode, which: keyCode }
@ajfuller I'll finish to update the changelog and I'll merge this PR, then we can release a version. |
Sorry I have |
dee03b7
to
c8b5fcd
Compare
@diasbruno I've cleaned this up so it's just the upgrade related changes. Other refactoring can be in a separate PR 😸. |
Fixes #[issue number].
Changes proposed:
react-addons-test-utils
in favor of accessing fromreact-dom/test-utils
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md
.