-
Notifications
You must be signed in to change notification settings - Fork 812
[change] v2.0.0. #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[change] v2.0.0. #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
271e015
to
311dc97
Compare
This was referenced Jun 15, 2017
* Add linting * Make specs pass linter * Make lib/helpers pass linter * Make lib/components pass linter This also does some signfiicant refactoring of the code to appease the linter's pro-ES2015+ stance. closes reactjs#289 closes reactjs#286 * Make travis run the lint task as well as specs closes reactjs#284
bf18a96
to
8bd85b5
Compare
Changes Unknown when pulling 8bd85b5 on diasbruno:feature/master-to-v1 into ** on reactjs:v1**. |
8bd85b5
to
1428a54
Compare
Changes Unknown when pulling 1428a54 on diasbruno:feature/master-to-v1 into ** on reactjs:v1**. |
638c53e
to
8221f6f
Compare
Changes Unknown when pulling 638c53e on diasbruno:feature/master-to-v1 into ** on reactjs:v1**. |
8221f6f
to
60ad47d
Compare
Changes Unknown when pulling 60ad47d on diasbruno:feature/master-to-v1 into ** on reactjs:v1**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is a result of all work done by @claydiffrient and other contributors.
Most commits available on
master
will be ported tov1
to make things easier and safer.Small commits will be added with
git am
to preserve the original patch.Some patches were reworked to clean up.
Thank you all for the great work.
Commits checklist:
6442387 [changed] use object className and overlayClassName prop to override the default content and overlay classes; use bodyOpenClassName to override body class name when modal opened [already on v1]
c184ddf Add gzip size badge [already on v1]
38dfc8d Use callback ref in readme
ea3e536 Add changelog entries from the v1 branch
37a6ceb Update README for issue close modal when user click on overlay (#352)
a8b7aa0 [chore] use afterEach to cleanup modals automatically. [already on v1]
ba2fe90 [fixed] respect closeTimeoutMS during unmount [already on v1]
ebec638 [change] improve reliability on focus management. [already on v1]
6ba1c8d (restrry/master) [fixed] Enable click to close in iOS (#301) (#304) (#313) [already on v1]
75a1aa3 [fixed] Infinite loop in tab scoping [fixed when updated javascript syntax]
ad9e115 Updates License (#303)
8108173 Modify the sample code to es2015 syntax in README.md (#295)
a776118 Get rid of CommonJS module (#299) [fixed when updated javascript syntax]
d50918c [fixed] Fix
this
scope (#296) [fixed when updated javascript syntax]e10181d Add badges to readme
3d6142c Setup coveralls and fix some code climate stuff [squashed with previous commit]
721cc1e Add language for CC duplication engine [squashed with previous commit]
a09ff8d Add code climate and code coverage
596f423 Add Linting (#293)
Commits to be added later:
baa1751 [changed] Replace appElement with getAppElement
9cb8441 Update bundling scheme (#347) [needs review]
0dc486a Add sauce labs reporter for better SL statuses
a1287bc Add cross browser testing via SauceLabs (#298)
b261459 Add sauce labs support
Acceptance Checklist:
CONTRIBUTING.md
.