Skip to content

Comment the ellipsis in code blocks in docs/index.md #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ADTC
Copy link
Contributor

@ADTC ADTC commented Sep 25, 2023

Super simple change, but it is to ensure proper syntax highlighting in http://reactcommunity.org/react-modal/

Right now it's showing error on the ellipsis because it's not a valid entity in JSX. This also affects the line after the ellipsis.

image

Once the ellipsis is commented out, the syntax highlighting should become correct for the line after it.

Changes proposed:

  • Comment the ellipsis in code blocks in docs/index.md

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@diasbruno
Copy link
Collaborator

Thanks, @ADTC.

@diasbruno diasbruno merged commit 96a81be into reactjs:master Feb 8, 2024
@ADTC
Copy link
Contributor Author

ADTC commented Feb 8, 2024

Thanks for the merge! I think we need to check the rest of the documentation as well.

@ADTC ADTC deleted the patch-1 branch February 8, 2024 13:53
@diasbruno
Copy link
Collaborator

Yep. I'll rebuild the documentation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants