Add BuildApp and WithInstance methods to builder #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces BuildApp for building and returning a ReactiveUI instance, and adds a set of WithInstance methods supporting up to 16 generic parameters to resolve and pass services to actions for chaining. These additions improve the flexibility and usability of the ReactiveUIBuilder API.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a BuildApp method to the ReactiveUI builder that builds and returns a ReactiveUIInstance wrapper, along with a comprehensive set of WithInstance methods supporting 1-16 generic parameters for dependency injection chaining. This enhances the builder API's flexibility by allowing fluent method chaining with resolved services.
Corrects the usage of GetService<T>() in ReactiveUIBuilder to remove unnecessary nullable type arguments, ensuring proper service resolution. Also updates Splat to 16.2.1 and Reactive.Wasm to 3.0.1 in Directory.Packages.props.
Eliminated unnecessary <exception cref="System.ArgumentNullException"> documentation from WithInstance method overloads and BuildApp in ReactiveUIBuilder.cs to reduce clutter and improve code readability.
Introduces the BuildApp method for building the application and returning an IReactiveUIInstance. Adds overloaded WithInstance methods supporting up to 16 generic parameters, allowing resolution of multiple instances and passing them to actions for chaining.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
==========================================
- Coverage 38.03% 35.85% -2.19%
==========================================
Files 132 138 +6
Lines 5489 5887 +398
Branches 825 885 +60
==========================================
+ Hits 2088 2111 +23
- Misses 3188 3614 +426
+ Partials 213 162 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature update
What is the new behavior?
Introduces BuildApp for building and returning a ReactiveUI instance, and adds a set of WithInstance methods supporting up to 16 generic parameters to resolve and pass services to actions for chaining. These additions improve the flexibility and usability of the ReactiveUIBuilder API.
What might this PR break?
None
Please check if the PR fulfills these requirements
Other information: